search

CookieJarApps / SmartCookieWeb

A secure, open source web browser for Android.
Mozilla Public License 2.0
297 stars 39 forks source link

[Bug] Userscripts don’t load @require resources #227

Closed LAbare closed 3 years ago

LAbare commented 3 years ago

I don’t know if it’s planned for a future release/later, so I’m labeling it as a bug. I’m still on v12.0.1, but scanning through the recent commits it doesn’t seem to have been fixed already.

Userscripts don’t load resources from the @require tag, which means that a lot of them which require external resources like jQuery will silently fail to work.

To test/reproduce

  1. Install this test userscript from here
  2. Go to smartcookieweb.com
  3. If the resource has been loaded, the userscript will display "@require test successful!" in an alert window; otherwise, it will display the JS error ("ReferenceError: SCW is not defined") in an alert window.
CookieJarApps commented 3 years ago

I added columns to the database ready to add support for UserScript versions, descriptions, namespaces, permissions and the run-at tag, but there isn't space for @require at the moment, so I'll make sure the next update includes an updated database and hopefully support for the tag.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

CookieJarApps commented 3 years ago

I'm working on this now.

CookieJarApps commented 3 years ago

Done! 60875baf2e1d834b47750df66af93e7b3a75b30a

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.