search

CookieJarApps / SmartCookieWeb

A secure, open source web browser for Android.
Mozilla Public License 2.0
297 stars 39 forks source link

[Bug] Crash When Attempting to Add Userscripts With JavaScript Disabled #294

Closed moriel5 closed 2 years ago

moriel5 commented 2 years ago

Device: Razer Phone 2 OS: Stock Android 9 ROM WebView: Google WebView 98.4758.87

I usually keep JavaScript disabled, and I had forgotten to enable it when attention to add a userscript (from GitHub, the official SmartCookieWeb scripts page no longer serves proper links, only redirecting to itself).

The result? A crash.

Expected Result: A JavaScript page without a prompt or a crash (if relying upon JavaScript to install scripts).

When enabled, no issues whatsoever adding scripts.

moriel5 commented 2 years ago

On version 16.3, SmartCookieWeb no longer crashes when loading a userscript with JavaScript disabled, however with JavaScript enabled, it crashes when attempting to install the userscript.

CookieJarApps commented 2 years ago

I think I've found the issue, but first to check, does userscript installation work if you have more than 1 tab open?

moriel5 commented 2 years ago

I'll check right now.

Update: It does not.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.