search

CookieMonsterTeam / CookieMonster

Addon for Cookie Clicker that offers a wide range of tools and statistics to enhance the game
MIT License
504 stars 206 forks source link

Fixed Golden Cookie percentage calculation to cdf #921 #1190

Closed Numbernaut closed 2 months ago

Numbernaut commented 2 months ago

Changes the Golden Cookie probability percentage to a cumulative percentage, yielding the cumulative distribution as described by @CptHampton here

resolves #921

DanielNoord commented 2 months ago

Please make the changes in the relevant files. The file you are changing should be the build output.

Numbernaut commented 2 months ago

Initially, I made the changes directly to the CookieMonster.js file, which I now realize wasn't the best approach. I also mistakenly pushed the entire repository, including generated files, which was not ideal.

I've since reset the branch, applied the changes only to the relevant src/ files, and have pushed the updated commit. The changes should now align with the expected workflow. Please review the updated pull request.

DanielNoord commented 2 months ago

Sorry just saw your message. Could you also run the build?

DanielNoord commented 2 months ago

Do you want this to be available on the normal version? Then we also need to run build.

Numbernaut commented 2 months ago

Did my last commit run the intended function?

DanielNoord commented 2 months ago

Yes it did.

I had a look at the code: shouldn't this be a toggle able feature? It seems like a breaking change that might not be appreciated by all users. Should we make this a setting to switch between the two calculations?

Numbernaut commented 2 months ago

I understand what u mean, but it would effectively switch between showing "<0%" nearly all the time and the proposed implementation (Probability that GC has spawned until now).

In the end, I am indifferent to both solutions. Maybe someone else can implement the switch, or if I should do it some pointers to relevant code snippets would be appreciated as i never really did UI