search

CookieMonsterTeam / CookieMonster

Addon for Cookie Clicker that offers a wide range of tools and statistics to enhance the game
MIT License
501 stars 206 forks source link

Check CM.Disp.Tooltip for legacy code #359

Closed DanielNoord closed 3 years ago

DanielNoord commented 3 years ago

I've noticed that this isn't actually doing anything, as Beautify(Game.Objects[name].getPrice()) is never matched in the string; maybe this is some legacy code to remove?

_Originally posted by @Chorizorro in https://github.com/Aktanusa/CookieMonster/pull/355#discussion_r531712864_

Aktanusa commented 3 years ago

It's the return string of the function that is being matched. This is still needed.

Edit: Notice that Beautify(Game.Objects[name].getPrice()) is not in quotes. You won't find it in the source CC. It's a dynamic string.

Edit 2: Added more more comments in #355

Chorizorro commented 3 years ago

Yep I understand that Beautify(Game.Objects[name].getPrice()) is a dynamic string, but it looks like the computed string is never matched in l('tooltip').innerHTML.

I'll add an example to illustrate this:

In my current test save, the original l('tooltip').innerHTML value when trying to sell 1 cursor is:

<div style="min-width:350px;padding:8px;">
    <div class="icon" style="float:left;margin-left:-8px;margin-top:-8px;background-position:0px 0px;"></div>
    <div style="float:right;text-align:right;">
        <span class="price">2.419 Quint</span>
        <div style="font-size:80%;opacity:0.7;line-height:90%;">Infinity worth<br>0% of bank<br></div>
    </div>
    <div class="name">Cursor</div>
    <small>[owned : 300</small>] <small>[free : 10</small>!]
    <div class="line"></div>
    <div class="description">Autoclicks once every 10 seconds.</div>
    <div class="line"></div>
    <div class="data">• each cursor produces <b>0</b> cookies per second<br>• 300 cursors producing <b>0</b> cookies per second (<b>0%</b> of total CpS)<br>• <b>68.82 Quindec</b> cookies clicked so far</div>
</div>

and the value of Beautify(Game.Objects[name].getPrice()), matched for the split is, 5.3 Quint, which corresponds to the effective price of buying 1 cursor. However, this string 5.3 Quint is nowhere to be found in the original string, leading to the split/join having no effect and the tooltip HTML being left unaltered. I can reproduce this both in single and bulk selling.

What I understand is that the intent of the code is to match the price in <span class="price">2.419 Quint</span> in order to replace it with a computed price (starting by a minus to show this is a sale). Maybe the game was wrongfully displaying the "buy" price instead of the "sell" one when being in sell mode, and this snippet of code was fixing it with the real sale price; however this is not doing anything anymore as the game shows the right "sell" price now.

For reference, the piece of code we're talking about is:

else if (Game.buyMode == -1) {
    if (Game.buyBulk == -1) {
        l('tooltip').innerHTML = l('tooltip').innerHTML.split(Beautify(Game.Objects[name].getPrice())).join('-' + Beautify(CM.Sim.BuildingSell(Game.Objects[name], Game.Objects[name].basePrice, Game.Objects[name].amount, Game.Objects[name].free, Game.Objects[name].amount)));
    }
    else {
        l('tooltip').innerHTML = l('tooltip').innerHTML.split(Beautify(Game.Objects[name].getPrice())).join('-' + Beautify(CM.Sim.BuildingSell(Game.Objects[name], Game.Objects[name].basePrice, Game.Objects[name].amount, Game.Objects[name].free, Game.buyBulk)));
    }
}

And my current test save:

Test save for import (click to expand) Mi4wMzF8fDE2MDQ0OTQ4MzM0MDU7MTU5OTE2NTg3MDY1ODsxNjA2NTgyNTA1MDM2O0Nob3Jpem9ycm8gdGVzdDtjZ2xxaXwwMTExMTAwMTAxMDEwMDEwMDEwMTB8MS42Mzc1MzczNjIzODE4NzE3ZSs1MzszLjA0NDM5NTY5NDUzNzU0M2UrNTM7MjI0NzU7MTI4NzE7MS44NTcxNjYwMjE1NzY3MzQ0ZSs1Mzs2NjA2OzA7MDsyLjU5MzQzNTkwNTc0NzA3NzdlKzUxOzA7MTswOzA7LTE7MTAyOzQwNTQ7OC40MTU4NDI4ODMwODY1MDRlKzQ4OzExNzsxNDsyMDstMTs0OzswOzA7MTM3MzkxMDcwMTkxNzI7MTE1NTIyNTY4MzEwODA7MjE4Njg1MDE4ODA5MjswOzA7MDsxOzI7Mzs0OzI1OzE4OzU7MDs1MDswOzA7MTE7MTU2OzE2MDY1NDc4MzU0MjM7MDswOzEyOSwyMjc7NDE7MTsxOzcuODA1OTQxNDAxODc1ODg2ZSs0NDt8MzAwLDE3ODIsNi44ODE5ODM5OTE1NjU2MTNlKzQ5LDcsLDAsODMwOzMwMCwxNDYwLDYuMTA4MzUzODIxNzI4NTc3ZSs0OSwxLCwwLDgxMDszMDAsMTQwMCwyLjM3NzcwNDQ4NTI3OTEzM2UrNDYsMTAsMTYwNjU4MzMwMjY0NToyOjE2MDYzMTA3MTQyNjI6MDo5MDY6MzExOToxOjQ6MTYwNDQ5NDgzMzQxODogMTExMTEwMTAwMTExMTEwMDAwMTAwMDAxMTAwMDAwMDAwMCAzOjE1OjA6MDozOjE0OjA6MDozOjg6MDowOjM6MTI6MDowOjM6MTI6MDowOjM6MTQ6MDowOjM6MTI6MzoxMDozOjk6MDowOjM6MTM6MDowOjM6MTE6MDowOjM6MTM6MDowOjM6ODowOjA6MzoxMjowOjA6MzoxMzowOjA6Mzo5OjA6MDozOjk6MDowOjM6MTA6MDowOjM6MTM6MDowOiwwLDc1MDszMDAsMTQwMCwxLjk0ODE3NzI2MDk0NjMzOWUrNDgsMCwsMSw3NTA7MzAwLDEzNzAsMi41MjE2Mjc2MDEyOTE2MTE3ZSs0NywwLCwxLDcyMDszMDAsMTM2MCw1LjQzODg5MTAzNDE5ODEyNGUrNDYsMSwyOjI4OjE6OTgxNzg3LjM1MDA5NTA3MDQ6MDogNDc4OjI6LTIxOjIwODowOjA6MCE1NjY6MjotMzI6Mzc3OjA6MDowITQyNDI6NDotNTc6NDg5OjA6MDowITEzMjM6NDotMTY5OjQ2OjA6MDowITE5OTI6NTotMzc6NjI4OjA6MDowITU3MTI6MDotMjoyNjowOjA6MCEzNzM1OjI6LTQ3OjMwNTowOjA6MCE1MTgzOjU6LTU3OjEwOjA6MDowITEwMDEwOjE6MTA6MTc3OjA6MDowITEwMTkxOjA6LTU6NDIyOjA6MDowITEwNTY3OjU6MzE6ODQ6MDowOjAhNDAwMDo0Oi0xNzQ6MjEzOjA6MDowITQ5OTY6NDotMjAxOjQ3ODowOjA6MCExMDg0NDo0Oi0xNTI6MTUwOjA6MDowITE0NTkzOjA6LTExOjY0NzowOjA6MCExNjIxNjo1OjI4OjM0NTowOjA6MCEgMSwwLDcxMDszMDAsMTM1MCwyLjQ1MDUxMDUyMjU5NDExN2UrNDcsMSwxMC84LzYgMyAxNjA0OTIwMDM5NTUyIDEsMCw3MDA7MzAwLDE5NzAsNy4xNjc4NzY5OTE1NzAzOWUrNDYsMTAsODQgMjA4IDExMjQgMSwwLDY4MDszMDAsMTI5MCwxLjkwODYxMDQ3NTkyODU1NzVlKzQ2LDAsLDEsNjQwOzMwMCwxMjgxLDEuMDA4MTIzMjM0NDExOTEzNmUrNDcsMSwsMSw2MzA7MzAwLDEyOTAsMS41MTI2MTYyMzA2MjkwMjU4ZSs0OSwxLCwxLDY0MDszMDAsMTI1MCwzLjQwNzM4NDY0ODQ0NjUzMzdlKzQ4LDAsLDEsNjAwOzMwMCwxMjUwLDMuMzc4MzczODk4ODY1NDgxZSs0OSwwLCwxLDYwMDszMDAsMTIzMCwxLjk0NDAyNjA5MjEzNTA5MWUrNTAsMCwsMSw1ODA7MzAwLDEyMTAsNC42MDU2ODY3NTYxNDA4NjdlKzUwLDAsLDEsNTYwOzMwMCwxMjEwLDMuMTM0NjkyMjg3MDUxNDkyZSs1MSwwLCwxLDU2MDszMDAsMTE2MCw2LjIxMjUwNDcwNTI0MjcwNmUrNTAsMCwsMSw1MTA7MzAxLDExNDcsMi40OTMwNzczNDg5NDE0NjE2ZSs1MSwxLCwxLDQ5MDt8MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTEwMDExMTExMTAwMTExMDExMDAxMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTAxMDEwMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTExMTExMTExMTExMTAxMDEwMDAwMDAwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAwMDAwMDAwMDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMTExMTExMTEwMDAwMDAwMDExMTExMTExfDExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAwMDAwMDAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTEwMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMDEwMDAwMTAwMDAwMDExMTAxMTExMTExMTExMTAxMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMDEwMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEwMTExMTExMTExMTExMTExMTExMTAxMTExMTAxMDExMTEwMDAwMDEwMTEwMDAwMTExMTExMTExMTExMTExMTEwMDExMTExMTExMTExMTEwMDAwMTExMTExMTExMTAwMDExMTAxMTExMDAwMDAwMDB8fA%3D%3D%21END%21
Aktanusa commented 3 years ago

I see what you mean. Indeed in a newer version of CC this may be the case. In this case, I will agree this is legacy code, though maybe not as I would still like to add the minus sign. CM may now be looking for the wrong value. If i get a chance, I will look more closely, but I am unsure when that would be. If you could be so kind to look in my place @DanielNoord.

Edit: I took a look and indeed the number has changed. I guess Orteil did fix it, lol. I still would like to add the minus however, so I think the code just needs to be reworked to add the minus now.

DanielNoord commented 3 years ago

I agree with @Chorizorro that this seems to be legacy code. The game now calls Game.Objects[object].bulkPrice to determine which price to display. And this does display the correct price.

CM is thus not even calling the correct price. I don't really understand why we would want to add the minus to the tooltip. I understand that you get sort of a 'minus price' when selling something, but I think it is actually quite clear already. Adding the minus might confuse people.

Chorizorro commented 3 years ago

I've been doing it a bit more testing, and it appears that the Game.Objects[object].bulkPrice computed by the game is still incorrect, whereas the price computed by CM.Sim.BuildingSell appears to be right.

This piece of code is therefore still relevant and needs to be updated. (I've a fix that is almost ready, I just need to find the time to test it and push it)

DanielNoord commented 3 years ago

Are you sure? I just took a quick look at the source code and the function this.buy for buildings calls this.getPrice(). .bulkPrice calls .getSumPrice which seems to be the same code, just with a different amount. Therefore, I don't see how Game.Objects[object].bulkPrice can return an incorrect sell price. However, you have put much more time in this section of the code so please tell me if I overlooked something!

Chorizorro commented 3 years ago

While playing without any add-on loaded, I noticed that the amount of cookies I was earning by selling a building was different to what the game showed me beforehand, and I could reproduce it multiple times. However I don't know what causes the Game.Objects[object].bulkPrice to be incorrect. I think I'll investigate a bit further into this to make a bug report.

DanielNoord commented 3 years ago

Okay! Let me know if I can help anywhere!

Chorizorro commented 3 years ago

I was finally able to understand what was going on after a few hours playing with the debugger.

What's wrong in Cookie Clicker (no mod)

Selling price calculation VS sell method

There is only one tiny difference between the code calculating the selling price of a building, and the code processing the sale. Considering n the current number of the object we want to sell, and amount the amount of object we want to sell:

Code for Game.Object.getReverseSumPrice lines 6917 to 6927 (click to expand) ```javascript this.getReverseSumPrice=function(amount)//return how much you'd get from selling [amount] of this building { var price=0; for (var i=Math.max(0,(this.amount)-amount);i
Code for the selling loop in Game.Object.sell lines 6974 to 6994 (click to expand) ```javascript for (var i=0;i0) { sold++; moni+=price; Game.cookies+=price; Game.cookiesEarned=Math.max(Game.cookies,Game.cookiesEarned);//this is to avoid players getting the cheater achievement when selling buildings that have a higher price than they used to this.amount--; price=this.getPrice(); this.price=price; if (this.sellFunction) this.sellFunction(); Game.recalculateGains=1; if (this.amount==0 && this.id!=0) l('row'+this.id).classList.remove('enabled'); Game.BuildingsOwned--; success=1; } } ```

Example

From a fresh new game, no upgrades, no ascension, no auras... The simplest possible case. I currently have 7 cursors. The last bought cursor (7) cost me 35 🍪, the next one (8) will cost me 40 🍪.

The Cursor frame and the tooltip shows me that, selling my last bought cursor (7) will give me 9 🍪 which seems to be correct: Cursor.basePrice is 15, the one we're selling is the 7th, the Game.priceIncrease is a constant 1.15, Game.modifyBuildingPrice doesn't change the price and the sell multiplier is the default 0.25. Giving us:

⌈ 15 1.15^(7 - 1) 0.25 ⌉ = ⌈ 8.67 ⌉ = 9 (The reason why we have (7 - 1) as price increase exponent is because there is no price increase for the 1st boughe object, meaning it starts from 0 for the object 1)

However, the selling method uses the current price of the object, which corresponds to the price of the NEXT object to be bought, resulting in earning 10 🍪 by selling the last bought cursor (7). The getPrice method returns this:

⌈ 15 * 1.15^7 ⌉ = ⌈ 39.9 ⌉ = 40

which is then computed into the following:

⌊ 40 * 0.25 ⌋ = ⌊ 10 ⌋ = 10

I think this means that selling buildings always gives more 🍪 than it should, because the base price used is the one of the next object to be bought, not the price of the last one bought.

Test save Mi4wMzF8fDE2MDY3MjI4ODU0ODI7MTYwNjcyMjg4NTQ4MjsxNjA2NzIzODkxMDYzO1Bvd2VyIENsaWNrO2FudnFrfDExMTExMTAxMTAwMTAwMTAwMTAxMHw1ODQuNzY2NjY2NjY2Mzg5Nzs3NzguNzY2NjY2NjY2MjIwNTsxNjc7MDsxNjc7MTswOzA7MDswOzA7MDswOzA7MDswOzA7MDswOzA7MDswOzswOzA7MDswOzA7MDswOy0xOy0xOy0xOy0xOy0xOzA7MDswOzA7NTA7MDswOy0xOy0xOzE2MDY3MjI4ODU0ODA7MDswOzs0MTswOzA7MC43MDAwMDAwMDAwMDAwMDAxO3w3LDgsNjExLDAsLDAsNzswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwOzAsMCwwLDAsLDAsMDswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwOzAsMCwwLDAsLDAsMDswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwOzAsMCwwLDAsLDAsMDswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwOzAsMCwwLDAsLDAsMDswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwOzAsMCwwLDAsLDAsMDswLDAsMCwwLCwwLDA7MCwwLDAsMCwsMCwwO3wxMDEwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDB8MTAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDExMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMHx8%21END%21

Bulk selling

Bulk selling suffers the exact same problem: when selling 10 objects, the tooltip will show an amount based on the sum of the 10 last bought objects, whereas the sell method will compute an amount based on the price of the next object + the 9 last bought objects.

There is always an offset of 1 object between the base price calculated in the display, and the one calculated during the sale.

What about Cookie Monster

Even if the effective sale price of objects seems to be the one invalid, Cookie Monster needs to display the real number of 🍪 earned by selling a building. The CM.Sim.buildingSell should be able to do that easily.

There is currently a bug making the 🍪 earned by selling a building always be calculated with optimal auras (ES + RB), but I've already found a workaround.

DanielNoord commented 3 years ago

Very good work! You might want to submit a bug-report to Orteil, as I think he need to choose which price he wants to actually use. In the meantime we can make CM display the real number. I do think it will be good to annotate that extensively, maybe referring to this issue, so when Orteil fixes this bug we can immediately change CM.

With regards to the second bug, I assume you will tackle both when you submit a PR that fixes this issue?

Chorizorro commented 3 years ago

Thanks! Yes I'm going to do that. Do you know if there is an easy way to submit a bug report to Cookie Clicker by any chance? The only way I've found so far is by joining their Discord, which annoys me a bit.

Absolutely, the upcoming PR should fix everything! Hopefully I will be able to push this today.

DanielNoord commented 3 years ago

Not that I know of. Perhaps via Twitter or tumblr? I don't see any other communication channels on the site and his personal site...

Chorizorro commented 3 years ago

Thanks for the confirmation.

Yup, I think I'll take the time to go on Discord and talk a bit about this issue anyway, just to make sure it isn't already a well-known and documented issue and not bother Orteil with it if it's not necessary

DanielNoord commented 3 years ago

With #372 I think we can keep this issue closed right?

Chorizorro commented 3 years ago

Yes, I think so, as the bug is now fixed! (I may post one more comment in this issue if I have any feedback from Orteil / the Discord community)

Chorizorro commented 3 years ago

Quick update: I just reported it on the Cookie Clicker Discord, it seems like the bug was unknown and has been added to a "to-report" list. Also, some people were happy to know that they weren't going nuts by always earning more 🍪 than expected when selling their buildings 😄