CookiePLMonster / SilentPatch

SilentPatch for GTA III, Vice City, and San Andreas
MIT License
388 stars 15 forks source link

Radar issue returns when using interface mods (GTA III and GTA VC) #107

Closed GTAGamingChannel44 closed 6 days ago

GTAGamingChannel44 commented 2 weeks ago

This mod finally fixed the radar position in GTA III and Vice City but when using interface mods, such as Remastered HUD Interface for Vice City, the radar gap returns, so I hope you fix the issue. This comparison below is an example:

Without Interface mods:

Screenshot (124)

After Adding Interface mods (in this case I am using the "Remastered HUD Interface" mod:

Screenshot (123)

I hope you look into it and fix the compatiblity issue

CookiePLMonster commented 2 weeks ago

There is nothing I can do here, this mod is simply authored incorrectly and its radar disc is too small. In fact, because SP enlarges the disc I half expect this issue to manifest with this texture even without the patch.

GTAGamingChannel44 commented 2 weeks ago

Ok thanks, maybe you're right. By the way, I am about to walkthrough GTA III, Vice City and San Andreas using Zolika1351's Chaos Mod (it's usually called ZChaos) I hope that this update is compatible with the chaos mod. And something else, you've to update your GInput mod, because I have a minor visual problem with it, few months ago when I was doing the final mission in GTA Vice City, the first letter of the word "safe" text where it says "The Mafia is stealing your money, defend the safe" is overrided with gamepad icon. Something like this:

Screenshot (125)

I hope you look into this issue and hopefully try to fix it.

CookiePLMonster commented 2 weeks ago

This GXT text uses an invalid color code. If GInput ever gets an update it'll be fixed, for now it's the only text in the game to use that code.

GTAGamingChannel44 commented 2 weeks ago

Ok man, thanks.

CookiePLMonster commented 1 week ago

As for the radar size, the disc has been shrunk by 2px (units) as otherwise gaps on the inside appeared (like they do on VC Xbox!). Can you share a link to this UI mod? I guess I can take a quick look if it'd be fixed by optionally undoing that. But I fear gaps will then simply appear on the inside.

GTAGamingChannel44 commented 1 week ago

Ok man, here it is, sorry for being late:

Remastered HUD Interface: https://www.mixmods.com.br/2021/02/vc-remastered-hud-interface-interface-em-hd/

I hope the issue is easy to fix and without any consequences

CookiePLMonster commented 1 week ago

I hope the issue is easy to fix and without any consequences

It's not a bug per se, rather the mod is created around the radar scaling incorrectly. But it may be possible to account for it with an INI option..

GTAGamingChannel44 commented 1 week ago

Nice, so I hope the radar disc issue will become extremely less noticible or fixed all together.

CookiePLMonster commented 1 week ago

@GTAGamingChannel44 I looked into this and it doesn't seem to be a SP bug, the radar disc texture is ruined by texture compression. I compared it in 4K, and the results are:

No SilentPatch: no-sp

SilentPatch with a shrunk radar disc (current behaviour): sp-small

SilentPatch without a shrunk radar disc (the option I planned to add): sp-big

The artifacts on the edges are identical on all three screenshots, which shows they are not the map textures bleeding through. And indeed, looking at a raw radar disc texture from this mod, you can easily see the miscolored edges when you zoom in: radardisc

Unless you meant something else and not those miscolorations on the disc edges, I am doing to close this issue as invalid.

GTAGamingChannel44 commented 6 days ago

Dang it man, this UI mod is very faithful to the game (it's also recommended by a lot modders as a vanilla-friendly UI mod) and it's very sad that is has this big issue, but thank you so much for the heads up.

So it's turns out that the problem is not the SP's issue but rather the UI creator's mistake becuase this mod was built on non-4K or non-1440p resolutions. Can you tell me whether or not this radar issue is noticable with 4K resolutions or it will only be noticable if you actually looked at it very carefully?

CookiePLMonster commented 6 days ago

So it's turns out that the problem is not the SP's issue but rather the UI creator's mistake becuase this mod was built on non-4K or non-1440p resolutions. Can you tell me whether or not this radar issue is noticable with 4K resolutions or it will only be noticable if you actually looked at it very carefully?

The screenshots I made are in 4K so I'll let you judge that. It's not about the resolution but the texture compression, so it'll always look bad once you know what to look for.