search

CookiePLMonster / SilentPatch

SilentPatch for GTA III, Vice City, and San Andreas
MIT License
384 stars 15 forks source link

MSVC assembly fixups/cleanups #113

Closed TheComputerGuy96 closed 3 days ago

TheComputerGuy96 commented 1 week ago

This is a separate MR based on a suggestion in https://github.com/CookiePLMonster/SilentPatch/pull/95#issuecomment-2470023367

CookiePLMonster commented 1 week ago

Looks good overall, I'll give it a spin next time I am working on SP.

TheComputerGuy96 commented 3 days ago

@CookiePLMonster The SA part should probably be left unsquashed (because it's relatively big)

CookiePLMonster commented 3 days ago

OK, I see the review fix was force pushed, so even unsquashed history is clean. Fine by me then.