search

CookiePLMonster / SilentPatch

SilentPatch for GTA III, Vice City, and San Andreas
MIT License
384 stars 15 forks source link

III: Fix the missing window icon #118

Closed TheComputerGuy96 closed 5 days ago

TheComputerGuy96 commented 1 week ago

For some reason GTA 3 sets the hIcon value in WNDCLASSA struct to NULL which causes the window icon to be the default one (this was fixed in Vice City)

Fixes #117

CookiePLMonster commented 1 week ago

Please don't add new fixes using addresses. Use patterns.

TheComputerGuy96 commented 1 week ago

Hopefully this pattern is good enough

CookiePLMonster commented 1 week ago

Hopefully this pattern is good enough

The pattern looks good, yeah. Added just one extra comment.

Also can you add it to https://github.com/CookiePLMonster/SilentPatch/blob/dev/CHANGELOG-III.md in "Other fixes", just above the configurable ones?

CookiePLMonster commented 5 days ago

Verified working fine in III and failing the pattern match gracefully in VC. Thanks!

I also realized why I never noticed it myself - the windowed mode from UAL adds this icon automatically by itself.