CookiePLMonster / SilentPatch

SilentPatch for GTA III, Vice City, and San Andreas
MIT License
136 stars 8 forks source link

Money/one-time pickups leak objects if the pickup pool is exhausted #21

Closed CookiePLMonster closed 2 days ago

CookiePLMonster commented 7 months ago

in CPickups::GenerateNewOne if there's no free pickup slots it searches for either existing PICKUP_MONEY or PICKUP_ONCE_TIMEOUT to replace it with a new pickup, but doesn't do CWorld::Remove on the object and it doesn't remove it from the pool

CookiePLMonster commented 5 months ago

Only GTA III is affected, Rockstar fixed this in VC/SA.