CookiePLMonster / SilentPatch

SilentPatch for GTA III, Vice City, and San Andreas
MIT License
388 stars 15 forks source link

GTA III/VC don't start on Insider Windows 11 24H2 (26120.2200) #32

Closed iGom closed 1 month ago

iGom commented 1 month ago

Not sure if this is a 24H2 update issue but GTA 3 and VC won't launch on my system with the new SilentPatch+ddraw (old as well) I checked it on freshly installed versions from Steam, the only way for me to run them is to use re3/reVC

Video https://github.com/user-attachments/assets/91aec729-cc56-40bb-840a-965a251f2e3b https://github.com/user-attachments/assets/4ffccc4c-42c9-4362-9b26-1347afe350c4

iGom commented 1 month ago

SA works fine

edit: according to the event viewer both games crashes with the exception code 0xc0000005

AppName gta3.exe 
  AppVersion 0.0.0.0 
  AppTimeStamp 4c2cc921 
  ModuleName gta3.exe 
  ModuleVersion 0.0.0.0 
  ModuleTimeStamp 4c2cc921 
  ExceptionCode c0000005 
  FaultingOffset 0059128d
AppName gta-vc.exe 
  AppVersion 0.0.0.0 
  AppTimeStamp 48982736 
  ModuleName gta-vc.exe 
  ModuleVersion 0.0.0.0 
  ModuleTimeStamp 48982736 
  ExceptionCode c0000005 
  FaultingOffset 00640316 
iGom commented 1 month ago

ok, found the issue Force randomization for images (ASLR mandatory) under App and Browse in Windows Defender Security Center is now globally on Windows 11, disabling this for 3/VC EXEs allows games to run image

I guess it's not something that SP could fix as the problem is with the game EXEs

CookiePLMonster commented 1 month ago

I guess it's not something that SP could fix as the problem is with the game EXEs

That depends, because in this SP update I actually made sure that III/VC patches can deal with ASLR if it's present. The main question is - do they work without SP? If they launch and the patch makes it crash, then it's a problem on my end that I need to fix. If they can't even boot, I'm almost 100% certain it will be unfixable - for example, last time I checked I found out that the very old steamstub version used in the Steam releases of III and VC can't handle ASLR, and I cannot do anything about that.

In fact, perhaps this is your issue? I recommend to try stripping Steamstub out of those executables with Steamless. You should be able to use Mandatory ASLR fine then.

iGom commented 1 month ago

The main question is - do they work without SP? Nope until Mandatory ASLR is disabled for them In fact, perhaps this is your issue? I recommend to try stripping Steamstub out of those executables with Steamless. You should be able to use Mandatory ASLR fine then.

I've never heard of Steamless, but it did the trick, now both of games start just fine with or without SP and Mandatory ASLR on

CookiePLMonster commented 1 month ago

Nice! In this case it's something that SP cannot realistically address. If it was broken in the game code itself then I probably could fix it in the DDraw Component, like I fix the DEP issues. But, Steamstub is out of reach.

Closing as solved since it works fine with SP.