Missing files when rebuilding certain games

CookiePLMonster / mkpsxiso

ISO disc image maker written specifically for PlayStation homebrew development

GNU General Public License v2.0

15 stars 3 forks source link

Missing files when rebuilding certain games #25

Closed mateusfavarin closed 1 year ago

mateusfavarin commented 1 year ago

Some files don't build when using mkpsxiso.

Repro case: use dumpsxiso on Crash Team Racing (PAL) sha256: AF7FDE1DE43C7771E269768DCF9D03FC4759DB0ECF5D441D50325E7EBB3B3E20, and then rebuild the disc with mkpsxiso using the automated XML from dumpsxiso. The disc built will be missing most XA files in XA/LANG/*.XA folders. Note that dumpsxiso can correctly identify and extract the files, but mkpsxiso fails to build them into the disc.

CookiePLMonster commented 1 year ago

Just checking - does https://github.com/CookiePLMonster/mkpsxiso/pull/24 fix it?

mateusfavarin commented 1 year ago

Built the develop branch locally and tested on the game. XA files are still missing after rebuilding. If it helps, the game file structure for the XA files is:

XA/DCH/EXTRA/*.XA XA/DCH/GAME/*.XA XA/ENG/EXTRA/*.XA XA/ENG/GAME/*.XA ...

Every XA file in XA/DCH/* is correctly built, but other XAs from other folders are missing.

CookiePLMonster commented 1 year ago

Confirmed solved with https://github.com/Lameguy64/mkpsxiso/commit/9f6275f08829ea9de8122c8232a019e8724acbbd.