CoolLord22 / OtherDrops1.13

OtherDrops branch for the latest Minecraft version!
GNU General Public License v3.0
0 stars 4 forks source link

Heroes Plugin -ENHANCEMENT- with OtherDrops #22

Open fogracvxy opened 5 years ago

fogracvxy commented 5 years ago

Describe the bug A clear and concise description of what the bug is. I am mining ores with pickaxe it drops custom drops but It won't give any experience for destroying this block(mining) but works for any other block that is not added to custom drops I tried removing plugin from plugins folder and experience started to appear To Reproduce Steps to reproduce the behavior: Just mine any kind of ore that you added to custom drops It won't give experience for Heroes professions

Expected behavior A clear and concise description of what you expected to happen. It should give experience for class when ore is mined Screenshots If applicable, add screenshots to help explain your problem. Can't show it with picture Desktop (please complete the following information):

Additional context Add any other context about the problem here. Nothing else

CoolLord22 commented 5 years ago

Update on this issue- Heroes ignores canceled events (OtherDrops cancels the block break event and has to manually send the event to plugins). But unfortunately, Heroes doesn't have any implementations on notifying it of canceled events, so I'll have to manually add experience to the player depending on what skill was affected.

CoolLord22 commented 5 years ago

I'm gonna remove the "bug" feature because technically speaking it would be an issue on Heroes side of development, but I'll add enhancement to make it a feature that OD will reward the XP for Heroes instead.