search

CoolMineman / Plant-In-A-Jar

Advanced micro-greenhouse fabric mod that can grow any kind of plant including trees.
GNU Lesser General Public License v3.0
2 stars 7 forks source link

Crash when placing jar on Stockpile Barrel #2

Closed MorningSage closed 4 years ago

MorningSage commented 4 years ago

A friend of mine put one of the jars on a barrel from Stockpile and it crashed saying:

The FixedItemInv class me.branchpanic.mods.stockpile.impl.attribute.FixedMassItemInv didn't accept the stack 2 wheat_seeds in slot 0!

I’m assuming the issue is that the wheat crops produce both wheat and seeds and, since the barrel can only hold one, the seeds were sent back? Since the jar isn’t meant to be used as an inventory, the seeds are being rejected?

I haven’t looked into any of this much, so I may be TOTALLY off, but that’s the first thing that popped into my head. If you think it’s an issue with Stockpile or LibBlockAttributes (maybe saying the barrel can accept items when it can’t?), I’ll open a ticket there, too.

The full crash report: https://pastebin.com/CPksU9Di

MorningSage commented 4 years ago

So, I had some time and looked into the code here. It’s as simple as using the hopper logic. Which led us to do tests with the hopper itself and we were able to crash the game with that, too.

I’ve opened a ticket on Stackpile’s repo so we’ll let them handle this issue.

Thanks for making a stable mod!

https://github.com/branchpanic/stockpile/issues/100