search

CoolProp / CoolProp.jl

A Julia wrapper for CoolProp, offering access to thermodynamic properties for fluids and mixtures.
http://www.coolprop.org
Other
32 stars 15 forks source link

Fugacity functions update #35

Closed barche closed 11 months ago

barche commented 11 months ago

Rebase and update of PR #33

barche commented 11 months ago

@chris-hampel-CA can you please check if this is OK? If so we can merge and release a new CoolProp.jl version.

chris-hampel-CA commented 11 months ago

Hi @barche

Looks good to me. You can double check by looking at the output of the example fugacity calls in the testLow.jl file to see if they match the float64 values shown in the function docstrings.

A couple comments should be removed that I called out, however.

Also, I noticed a few other changes in the runtests.jl file which were not my changes. As long as you know that section is ok, then this PR is ready to go.

Thanks!