search

CoolerGangster / Create-Arcane-Engineering

A 1.18 Modpack
GNU General Public License v3.0
35 stars 27 forks source link

Fix some inconsistent arboreal extractor recipes by respecting thermal series #80

Open kui opened 8 months ago

kui commented 8 months ago

There are some inconsistence experience about Arboreal Extractor recipes. JEI shows that Resin is produced from vanilla Spruce and the rate is 50mB per operation. However, Arboreal Extractor attached to vanilla spruce trees produces 25mB of Resin per operation.

Vanilla Spruce Extraction Screenshot:

Vanilla Spruce Extraction Screenshot

This is because Arboreal Extractor looks up the output from the tree trunk block only. Here is the implemtation:

https://github.com/CoFH/ThermalCore/blob/b55443b053c0991a36fd36d3e192d8e825703f10/src/main/java/cofh/thermal/core/block/entity/device/DeviceTreeExtractorTile.java#L176

renderFluid = TreeExtractorManager.instance().getFluid(level.getBlockState(trunkPos));

So, the recipe is overridden by KubeJS in this modpack.

BYG Spruce Extraction Screenshot:

BYG Spruce Extraction Screenshot

By this implementation, modpack authors seems to be required to add the Arboreal Extractor recipe that is same output with the bundled recipes for existing trunk blocks.

This PR changes the rate of Resin production respecting the bundled recipes.

I'm sorry for my poor English. I hope this PR helps you.

kui commented 8 months ago

BOP Fir recipe: https://github.com/CoFH/ThermalIntegration/blob/22a975d5c94a119d402239619c9cd842b852ee25/src/main/resources/data/thermal/recipes/compat/biomesoplenty/tree_extractor_bop_fir.json#L5-L8