CoolerGangster / Create-Arcane-Engineering

A 1.18 Modpack
GNU General Public License v3.0
35 stars 27 forks source link

Final chapter obtainable blocks protected #93

Open Zincfox opened 6 months ago

Zincfox commented 6 months ago

(Chapter X spoilers)

The Stone used for the Ice Keystone is protected by arcane forces. While this makes cleanup when manually placing it for testing purposes a pain (have to use the TNT from the dispensers), this results in a larger problem when a running build runs out of TNT due to #91. This is especially problematic when the breaking-deployers are mounted on a contraption. As the stone is no longer being converted due to missing TNT, the deployers can no longer break the blocks. They still play the breaking animation, but once it would have been completed normally, they simply continue moving (at least with a sticky mechanical piston), potentially pushing the stone blocks in front of them - making space for the next unconvertable stone blocks to be deployed. As the push limit for create is 2048 (by default) and neither the stone blocks nor the walls of the chamber are resistant to being pushed, this can create a long line of stone to be pushed outside the chamber, which can no longer be cleaned up without creative mode or commands. In theory this stone line could also affect other chambers, but I believe they are always cleared once the current chamber is done anyway, in turn also destroying the pusher when the ice chamber is completed.

While stone is the most problematic block in this case, the display links provided in the chest are also unusable because they too are protected once placed (it is still possible to program them to other frequencies, but they cannot be toggled into receive mode and can only be broken by breaking/moving the block they are placed on afaik).

The fix for the display link is probably easy - I have not checked the coordinates in structure.js, but if the "protected" display links are simply added there, the entry in the forbidden list could be removed.

For the stone blocks maybe the forbidden list could be split based on chamber/location, preventing the breaking of stone wherever it is used in the walls, but allowing it to be broken in the ice chamber?

Also I'm not sure why minecraft:water is added to the forbidden list (twice), as it is collected with a bucket and therefore bypasses the check?