ios 7 bug - Githubissues

CooperRS / RMPickerViewController

This is an iOS control for selecting something using UIPickerView in an UIAlertController like manner

MIT License

381 stars 51 forks source link

ios 7 bug #26

Closed mrhaxic closed 9 years ago

mrhaxic commented 9 years ago

First we need to edit this line

if(UIAccessibilityIsReduceMotionEnabled()) { ... }

if(UIAccessibilityIsReduceMotionEnabled != NULL) { ... }

for avoiding crash on iOS 7.x but after show the picker on iOS 7 the whole view be white background see image please .. http://oi58.tinypic.com/20ruvex.jpg

Could you please tell me what is going wrong ?

CooperRS commented 9 years ago

Hi, which version of RMPickerViewController are you using?

mrhaxic commented 9 years ago

@CooperRS Hi, last version

mrhaxic commented 9 years ago

Pull of @jordanmaguire solved my problem, but for version 1.4.0 it is just for your information. Thanks

CooperRS commented 9 years ago

I just realized that UIAccessibilityIsReduceMotionEnabled() is only available in iOS 8 and later. That means that version 1.3.3 and above of RMPickerViewController actually require iOS 8 although I said it only requires iOS 7 (at least for version 1.3.3 I said that. Version 1.4.0 only supports iOS 7 if landscape mode is not supported in the app, see main page).

I think I'll push two new versions:

1.3.4 which supports iOS 7 even in apps which allow landscape mode
1.4.1 which supports iOS 7, if your app does not allow landscape mode. Otherwise iOS 8 is required.

CooperRS commented 9 years ago

Whoops, I don't know my own controls :D

So to clarify:

Version 1.3.3 is fully iOS 7 compatible
Version 1.4.0 uses UIAccessibilityIsReduceMotionEnabled() which only is available in iOS 8.0 and above. I'll fix that in version 1.4.1 which I will push in a few moments. Version 1.4.1 is then compatible to iOS 7 as described on the main page.

CooperRS commented 9 years ago

Version 1.4.1 has been pushed and should fix the problem

mrhaxic commented 9 years ago

Thanks :+1: