CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

CLXP-54 MVP Design Review and adjustement #2861

Closed HuyIT9898 closed 3 months ago

HuyIT9898 commented 3 months ago

Purpose: My learning MVP Design Review and adjustement

Review app: unable to create one cause out of snapshot allowed monthly for free account :(

preview: https://66224c8b94e874634f31de6b-fapxgxlxmo.chromatic.com/?path=/story/template-mylearning--default

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.97%. Comparing base (197bf7c) to head (7801b74). Report is 1 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2861 +/- ## ======================================= Coverage 93.97% 93.97% ======================================= Files 398 398 Lines 6121 6121 Branches 428 428 ======================================= Hits 5752 5752 Misses 291 291 Partials 78 78 ``` | [Files](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...ademy-components/src/template/my-learning/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Ftemplate%2Fmy-learning%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy90ZW1wbGF0ZS9teS1sZWFybmluZy9pbmRleC5qcw==) | `85.89% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [b69a37f...7801b74](https://app.codecov.io/gh/CoorpAcademy/components/pull/2861?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).
wernerdurand commented 3 months ago

Hi @HuyIT9898 Looks very good, but I noticed something weird with the search bar when using the suggestions, a weird light blue square appears Capture d’écran 2024-07-02 à 18 13 24

Everything else looks good!