search

CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

pass disabled props as button attribute #2869

Closed adamska27 closed 2 months ago

adamska27 commented 2 months ago

https://go1web.atlassian.net/jira/software/projects/CLXP/boards/626?selectedIssue=CLXP-86

Detailed purpose of the PR

fix disabled behavior on following components:

Result and observation

Testing Strategy

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.82%. Comparing base (5d9c153) to head (c1a3616). Report is 28 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2869 +/- ## ========================================== - Coverage 95.40% 93.82% -1.58% ========================================== Files 506 401 -105 Lines 8354 6205 -2149 Branches 428 429 +1 ========================================== - Hits 7970 5822 -2148 + Misses 306 305 -1 Partials 78 78 ``` | [Files](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...components/src/atom/button-link-icon-only/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fbutton-link-icon-only%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2J1dHRvbi1saW5rLWljb24tb25seS9pbmRleC5qcw==) | `100.00% <ø> (ø)` | | | [...pacademy-components/src/atom/button-link/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fbutton-link%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2J1dHRvbi1saW5rL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | | | [...pacademy-components/src/atom/button-menu/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fbutton-menu%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2J1dHRvbi1tZW51L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | | | [...es/@coorpacademy-components/src/atom/link/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Flink%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2xpbmsvaW5kZXguanM=) | `100.00% <ø> (ø)` | | ... and [105 files with indirect coverage changes](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [5d9c153...c1a3616](https://app.codecov.io/gh/CoorpAcademy/components/pull/2869?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).