search

CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

Fix skillBaseUrl not passed properly in Discipline template #2870

Closed HuyIT9898 closed 2 months ago

HuyIT9898 commented 2 months ago

Purpose: Fix skillBaseUrl not passed properly in Discipline template

Fix #2867

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.82%. Comparing base (2a40e77) to head (8823499). Report is 1 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2870 +/- ## ========================================== - Coverage 95.39% 93.82% -1.57% ========================================== Files 505 401 -104 Lines 8335 6204 -2131 Branches 428 428 ========================================== - Hits 7951 5821 -2130 + Misses 306 305 -1 Partials 78 78 ``` | [Files](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...components/src/template/common/discipline/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Ftemplate%2Fcommon%2Fdiscipline%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy90ZW1wbGF0ZS9jb21tb24vZGlzY2lwbGluZS9pbmRleC5qcw==) | `100.00% <ø> (ø)` | | ... and [104 files with indirect coverage changes](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [52b2aad...8823499](https://app.codecov.io/gh/CoorpAcademy/components/pull/2870?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).