search

CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

CLXP-110 Skill picker modal footer is hidden when zoom in on browser #2872

Closed HuyIT9898 closed 2 months ago

HuyIT9898 commented 2 months ago

Purpose: fix Skill picker modal footer is hidden when zoom in on browser

review app: https://6628d2e0fd4aa63f3be2e1ab-ywbzvisqli.chromatic.com/

125%: image

150%:

image

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.82%. Comparing base (a5d8946) to head (6a5c140). Report is 1 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2872/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2872 +/- ## ======================================= Coverage 93.82% 93.82% ======================================= Files 401 401 Lines 6205 6205 Branches 429 429 ======================================= Hits 5822 5822 Misses 305 305 Partials 78 78 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2872?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2872?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [68fc229...6a5c140](https://app.codecov.io/gh/CoorpAcademy/components/pull/2872?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).