CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

CLXP-63 Learning priority card #2873

Closed adamska27 closed 2 months ago

adamska27 commented 2 months ago

Detailed purpose of the PR

https://go1web.atlassian.net/jira/software/projects/CLXP/boards/626?selectedIssue=CLXP-63

Result and observation

image

chromatic link: https://6622682e70ecd8ecf5027fa1-lpswutqqwp.chromatic.com/?path=/story/molecule-learningprioritycard--certification-type-100

Testing Strategy

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.76%. Comparing base (a5d8946) to head (4d6ce7a). Report is 33 commits behind head on master.

Files Patch % Lines
...ents/src/molecule/learning-priority-card/index.tsx 76.47% 0 Missing and 4 partials :warning:
...omponents/src/atom/circular-progress-bar/index.tsx 85.71% 1 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2873 +/- ## ========================================== - Coverage 93.82% 93.76% -0.07% ========================================== Files 401 405 +4 Lines 6205 6239 +34 Branches 429 434 +5 ========================================== + Hits 5822 5850 +28 - Misses 305 306 +1 - Partials 78 83 +5 ``` | [Files](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...components/src/atom/circular-progress-bar/types.ts](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fcircular-progress-bar%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2NpcmN1bGFyLXByb2dyZXNzLWJhci90eXBlcy50cw==) | `100.00% <100.00%> (ø)` | | | [...ges/@coorpacademy-components/src/atom/tag/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Ftag%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL3RhZy9pbmRleC5qcw==) | `100.00% <100.00%> (ø)` | | | [...nents/src/molecule/learning-priority-card/types.ts](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Flearning-priority-card%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9sZWFybmluZy1wcmlvcml0eS1jYXJkL3R5cGVzLnRz) | `100.00% <100.00%> (ø)` | | | [...omponents/src/atom/circular-progress-bar/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fcircular-progress-bar%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2NpcmN1bGFyLXByb2dyZXNzLWJhci9pbmRleC50c3g=) | `85.71% <85.71%> (ø)` | | | [...ents/src/molecule/learning-priority-card/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Flearning-priority-card%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9sZWFybmluZy1wcmlvcml0eS1jYXJkL2luZGV4LnRzeA==) | `76.47% <76.47%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [ac54fff...4d6ce7a](https://app.codecov.io/gh/CoorpAcademy/components/pull/2873?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).
HuyIT9898 commented 2 months ago

Can you please add a chromatic review link for this?

adamska27 commented 2 months ago

https://6622682e70ecd8ecf5027fa1-lpswutqqwp.chromatic.com/?path=/story/molecule-learningprioritycard--certification-type-100

done đź‘Ť

https://6622682e70ecd8ecf5027fa1-lpswutqqwp.chromatic.com/?path=/story/molecule-learningprioritycard--certification-type-100