CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

CLXP-114 Enhancement Button Link component to have it own hover state #2876

Closed HuyIT9898 closed 1 month ago

HuyIT9898 commented 2 months ago

Purpose: Enhancement Button Link component to have it own hover state

ticket: https://go1web.atlassian.net/browse/CLXP-114

review app: https://6628d2e0fd4aa63f3be2e1ab-kubwsfxkvp.chromatic.com/

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (f93e602) to head (2a43cf3). Report is 1 commits behind head on master.

Files Patch % Lines
...pacademy-components/src/atom/button-link/index.tsx 83.33% 0 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2876 +/- ## ========================================== + Coverage 93.76% 93.78% +0.01% ========================================== Files 405 405 Lines 6239 6224 -15 Branches 434 435 +1 ========================================== - Hits 5850 5837 -13 Misses 306 306 + Partials 83 81 -2 ``` | [Files](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...rpacademy-components/src/atom/button-link/types.ts](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fbutton-link%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2J1dHRvbi1saW5rL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [...cademy-components/src/molecule/base-modal/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Fbase-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9iYXNlLW1vZGFsL2luZGV4Lmpz) | `88.23% <ø> (-1.77%)` | :arrow_down: | | [...omponents/src/molecule/learner-skill-card/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Flearner-skill-card%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9sZWFybmVyLXNraWxsLWNhcmQvaW5kZXguanM=) | `100.00% <ø> (ø)` | | | [...ents/src/molecule/learning-priority-card/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Flearning-priority-card%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9sZWFybmluZy1wcmlvcml0eS1jYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+23.52%)` | :arrow_up: | | [...cademy-components/src/molecule/skill-card/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fmolecule%2Fskill-card%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9tb2xlY3VsZS9za2lsbC1jYXJkL2luZGV4Lmpz) | `100.00% <ø> (ø)` | | | [...ademy-components/src/template/my-learning/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Ftemplate%2Fmy-learning%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy90ZW1wbGF0ZS9teS1sZWFybmluZy9pbmRleC5qcw==) | `85.33% <ø> (-1.09%)` | :arrow_down: | | [...demy-components/src/template/skill-detail/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Ftemplate%2Fskill-detail%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy90ZW1wbGF0ZS9za2lsbC1kZXRhaWwvaW5kZXguanM=) | `100.00% <ø> (ø)` | | | [...pacademy-components/src/atom/button-link/index.tsx](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Fatom%2Fbutton-link%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy9hdG9tL2J1dHRvbi1saW5rL2luZGV4LnRzeA==) | `95.74% <83.33%> (-4.26%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [f93e602...2a43cf3](https://app.codecov.io/gh/CoorpAcademy/components/pull/2876?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).