CoorpAcademy / components

[🌲] Front components for Coorpacademy
https://coorpacademy.github.io/components/components
6 stars 6 forks source link

[axa-climate] header or footer on top the scorm-player #2888

Closed esa-coorp closed 3 days ago

esa-coorp commented 4 days ago

To integrate the axa-climate courses, we need to test the scorm in fullscreen with the header and footer on top.

Result and observation

Testing Strategy

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.32%. Comparing base (aea43f2) to head (9ec6ffd). Report is 334 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888/graphs/tree.svg?width=650&height=150&src=pr&token=7OEgH5oYMi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy)](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ```diff @@ Coverage Diff @@ ## master #2888 +/- ## ========================================== - Coverage 93.97% 93.32% -0.65% ========================================== Files 398 410 +12 Lines 6122 6371 +249 Branches 428 436 +8 ========================================== + Hits 5753 5946 +193 - Misses 291 344 +53 - Partials 78 81 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) | Coverage Δ | | |---|---|---| | [...y-components/src/template/external-course/index.js](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?src=pr&el=tree&filepath=packages%2F%40coorpacademy-components%2Fsrc%2Ftemplate%2Fexternal-course%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy#diff-cGFja2FnZXMvQGNvb3JwYWNhZGVteS1jb21wb25lbnRzL3NyYy90ZW1wbGF0ZS9leHRlcm5hbC1jb3Vyc2UvaW5kZXguanM=) | `100.00% <ø> (ø)` | | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Last update [6ab0254...9ec6ffd](https://app.codecov.io/gh/CoorpAcademy/components/pull/2888?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CoorpAcademy).