search

Copenhagen-Alliance / versification-specification

Versification mappings and versification snifffing
17 stars 6 forks source link

JSON representation of VRS needs to handle one-to-many mappings #16

Closed jonathanrobie closed 3 years ago

jonathanrobie commented 3 years ago

Copied from https://github.com/bible-technology/scripture-burrito/issues/253

@mvahowe wrote:

Right now the mapping section of the "vrs-as-json" schema looks something like this:

        "mappedVerses": {
            "propertyNames": {
                "$ref": "#/definitions/bcvRange"
            },
            "additionalProperties": {
                "$ref": "#/definitions/bcvRange"
            }
        },

I don't think this handles one-to-many mappings, eg

PSA 51:0 = PSA 51:1
PSA 51:0 = PSA 51:2

In this case we have one property but need to represent two BCV ranges. This happens in standard versifications, and happens a lot more when mappings are reversed. Something like

PSA 51:0 = PSA 51:1-2

will create problems since existing VRS logic says that ranges have the same number of verses on each side.

I think that the cleanest way to address this is to make the properties an array of BCV ranges. (In the majority of cases there would be exactly one BCV range in each array.)

mvahowe commented 3 years ago

@jonathanrobie What was the reason for immediately closing this issue?

jonathanrobie commented 3 years ago

It is a duplicate of #15.

On Wed, Apr 7, 2021 at 12:03 PM Mark Howe @.***> wrote:

@jonathanrobie https://github.com/jonathanrobie What was the reason for immediately closing this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Copenhagen-Alliance/versification-specification/issues/16#issuecomment-815033699, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPTPMFW5AASJRVS3KZGC3THR66XANCNFSM42Q2ID4Q .