search

Copenhagen-Alliance / versification-specification

Versification mappings and versification snifffing
17 stars 6 forks source link

Issues with `rso.json` and `rsc.json` with PSA 115 #19

Closed RickBrannan closed 7 months ago

RickBrannan commented 7 months ago

I really appreciate this data, it is so helpful. However, in working with Russian Bible data, I notice an issue with mapping for PSA 115:10-19. Specifically, in rsc.json ("canonical" version of Russian Synodal), the line:

"PSA 115:0": "PSA 116:10",

should instead be:

"PSA 115:1-10": "PSA 116:10-19",

With rso.json ("orthodox" version of Russian Synodal), the line "PSA 115:1-10": "PSA 116:10-19", needs to be added, it appears to skip from PSA 114 to PSA 116.

jonathanrobie commented 7 months ago

Thanks for reporting this! Please let me know if the above pull request fixes the problem correctly.

RickBrannan commented 7 months ago

@jonathanrobie , this addresses the issues I was experiencing when mapping PSA 115 from the Russian Synodal. Thank you!