search

CopernicaMarketingSoftware / AMQP-CPP

C++ library for asynchronous non-blocking communication with RabbitMQ
Apache License 2.0
884 stars 340 forks source link

connection_name property is not set on windows platform #507

Open olejniczak opened 1 year ago

olejniczak commented 1 year ago

connectionstartframe.h:231

`#if defined(_WIN32) || defined(_WIN64) // i don't know that much about win32, so let's use hardcoded string if (!properties.contains("product")) properties["product"] = "application based on AMQP-CPP"; if (!properties.contains("platform")) properties["platform"] = "windows";

else

    // on unix-like systems I know how to retrieve application and platform info
    if (!properties.contains("product")) properties["product"] = ProgramName();
    if (!properties.contains("platform")) properties["platform"] = PlatformName();
    if (!properties.contains("connection_name")) properties["connection_name"] = ProgramName();

endif`

EmielBruijntjes commented 1 year ago

pull request?

olejniczak commented 1 year ago

I'm just looking for a quick and clean solution.