Closed ivanperez-keera closed 8 months ago
Change Manager: Confirmed that the spelling zephir
is present in the README and that it is a typo (the package name is indeed zephyr-copilot
).
Technical Lead: Confirmed that the issue should be addressed.
Technical Lead: Bug scheduled for fixing in Copilot 3.17.
Fix assigned to: @ivanperez-keera.
Implementor: Solution implemented, review requested.
Change Manager: Verified that:
Solution is implemented:
[X] The code proposed compiles and passes all tests. Details: Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/267041873
[X] The solution proposed produces the expected result. Details: The following Dockerfile checks that the misspelling Zephyr has been completely removed from the repo. When executed, it prints the message Success if the misspelled word cannot be found, and the word Failure otherwise.
FROM ubuntu:focal
ENV DEBIAN_FRONTEND=noninteractive RUN apt-get update RUN apt-get install --yes git moreutils RUN git config --global advice.detachedHead false
SHELL ["/bin/bash", "-c"] CMD git clone --quiet $REPO \ && cd $NAME \ && git checkout --quiet $COMMIT \ && (grep -rie 'zephir' copilot** | ifne false) \ && echo "Success" || echo "Failure"
Command (substitute variables based on new path after merge):
$ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=2310f70da905ce721dfe6d9b25b023b584615490" -it copilot-verify-459
Change Manager: Implementation ready to be merged.
Description
copilot
's README mentions a projectzephir-copilot
that is actually calledzephyr-copilot
.This typo should be corrected.
Type
Additional context
None.
Requester
Method to check presence of bug
Running a search through the tree brings up the mention:
Expected result
The output of the above
grep
command should be empty, indicating that the incorrect spelling cannot be found.Desired result
The output of the above
grep
command should be empty, indicating that the incorrect spelling cannot be found.Proposed solution
Fix the above mentioned typo.
Further notes
None.