Closed ivanperez-keera closed 6 days ago
Change Manager: Confirmed that the issue exists.
Technical Lead: Confirmed that the issue should be addressed.
Technical Lead: Issue scheduled for fixing in Copilot 4.1.
Fix assigned to: @ivanperez-keera .
Implementor: Solution implemented, review requested.
Change Manager: Verified that:
Solution is implemented:
Success
, indicating that there are no lines in any changelog where the issue number is followed by a period, where it follows anything other than a period or spaces, or where the date that denotes a new change block has anything after the day. Spaces are only needed when the issue number is the first element in a line, which is caused by line wrapping.
FROM ubuntu:focal
ENV DEBIAN_FRONTEND=noninteractive RUN apt-get update
RUN apt-get install --yes git
SHELL ["/bin/bash", "-c"]
CMD git clone $REPO \ && cd $NAME \ && git checkout $COMMIT \ && ! grep -e '#[0-9]+).$' copilot/CHANGELOG \ && ! grep -e '[^. ] (#[0-9]+)' copilot/CHANGELOG \ && ! grep -e '^202[0-9]-[0-9]{2}-[0-9]{2}.' copilot**/CHANGELOG \ && echo Success
Command (substitute variables based on new path after merge):
$ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=578eff68a4a59a4e99b3179fbf5d47e97881ee07" -it copilot-verify-550
Change Manager: Implementation ready to be merged.
Description
The CHANGELOGs contain lines with irregular formatting. It should be:
Comment. (#<issuenumber>)
but instead sometimes is:
Command (#<issuenumber)>.
Type
Additional context
None.
Requester
Method to check presence of bug
Running the following command lists all lines with the inconsistent formatting:
Expected result
Running the command above reports no lines, indicating that the format being used does not have that inconsistency.
Desired result
Running the command above reports no lines, indicating that the format being used does not have that inconsistency.
Proposed solution
Replace all lines that have that inconsistent formatting to use the format:
Comment. (#<issue_number>)
Further notes
None.