Closed ctschroeder closed 6 years ago
Reminder that deadline is March 19. Version # will be 2.5.0 Version date TBA -- 23 April? 16 April? (FYI I will be traveling, in NYC April 16-21.)
@eplatte pseudo-theophilus is ready for review. Corpus metadata and version date need to be added, but everything else is ready. There is one bright pink highlighted line in one of the docs, but otherwise it was straightforward. The first two docs were published before; the second two are new. Thanks!
Is March 19 the data freeze date?
Yes.
Sounds good
I was under the impression that March 19 was the submission deadline and April 1 would be the data freeze (i.e. all editing would be done by then). It doesn't really matter to me either way, although I have a conference from March 14 to March 18, so I'll need anything to review before then. If we want March 19 to be the data freeze, when do we want submissions? I'll need to email Christie and Marina to give them a new deadline.
My mistake. @amir-zeldes, @eplatte is right: March 19 submission, April 1 data freeze. My apologies!!
What date should we put on the version. April 1? 5? 8? We usually make small edits after the data freeze, because something comes up.
That's all fine. The release date can be the freeze date if you like - it won't really matter because there won't be a different publication version available online until after the initial release with that date. As long as we move forward in time with the dates all should be well!
April 1 for the release date sounds good to me!
for @amir-zeldes re AP validation: the "publish" or "to publish" or "review" AP that are not validating right now are ones that have validation errors we don't/I can't currently solve.
@ctschroeder Apa Johannes FA29-30 ready for review. See email for what happened to the other documents; hopefully I can get them done for Tuesday.
@ctschroeder Issue 1 is known and you don't need to do anything about it at the moment. For lacunae, I'd like to suggest we lemmatized them using the string UNKNOWN, to match the corresponding POS tag. Does that make sense? Then anything that has a POS tag also has a lemma, which is nice for consistency and may prevent all sorts of problems.
Alternatively we can also lemmatize them with their norm string (lemma=norm), I'm open to either.
lemma UNKNOWN sounds good to me. Thanks, @amir-zeldes. @eplatte: ok will check email.
got it, thanks
@amir-zeldes Mark 1-5 and 7 are marked for review in Gitdox. Is Mark 6 treebanked and ready, as well?
Also: anyone know why all those docs in ISYE corpus are marked "review"? @amir-zeldes @eplatte @bkrawiec We are not planning to republish, are we?
Those are documents with updated meta, but not for this publication. There may be other corpora like this, though most meta updates were in ISYE and AP I think. I still have some more to do as well.
No C.6 isn't treebanked so far.
@eplatte Re the empty cells not validating: I think this is an artifact of a merged cell or unmerged cell. I've seen it before, and I merge the non-validating cells with one below or above, unmerge, and it's fine.
I edited the apa johannes FA 33-34 file in sgml and reimported it into the spreadsheet. Something broke. the line breaks didn't import. I even tried reimporting the version-controlled sgml that's stored in gitdox (without my edits), and that file import didn't preserve the line breaks either. @amir-zeldes I don't know if this is an issue with gitdox or with the layer name.
Can you point me to the exact file in github that is not re-importable? Or send me the culprit via e-mail?
@amir-zeldes & @eplatte I think the AP are ready. Still working on the other corpora.
Fantastic, thanks!
@amir-zeldes @eplatte pseudo-theophilus should be ready
I just changed the lemmas for two cells in one of the docs. I hope you haven't started these yet. (sorry!!!)
the pseudo-theophilus I mean.
I just validated TEI, it's almost good to go:
Body validates fine.
Great. You are talking about pseudo-theophilus? I believe version@date and version@n are in each document.
I thought @eplatte was working on the corpus metadata so didn't even look at that. Thanks for the catch. One of us will get this.
The double quotes were in the metadata the last time around so I didn't know it was a problem. Would it be possible for you to add a validation check to our validation schema to catch this in the future? Will fix these docs later today.
I just checked ps-theophilus and version@date and version@n are there. Also, with the double quotes, will validation be a problem for linked metadata, since those have xml? I'll add the corpus metadata now!
I have made the edits to the document metadata. @eplatte I think all that's left is the corpus metadata. I still don't see it in there.
(I wonder if there is something wonky with corpus metadata?)
OK I just re-added the corpus metadata for ps-theo and re-checked that it's showing up in a separate document, so I think we should be good to go.
🙌🙌🙌
Sent from my iPhone
OK, sorry about the metadata, that was a very stupid bug (doc_id is NULL for corpus meta, doc_id must be unique or null, and corpus meta ID was being entered as String 'NULL' rather than actual NULL, so it overwrote the last corpus)
Should be fixed now. I added meta for AP based on the previous corpus, but then it occurred to me that maybe the list of annotation/translation changes? Could you check @eplatte and enter the Johannes meta again? Sorry about this!
made the changes to pseudo-theophilus. That corpus is ready for redoing.
@amir-zeldes @eplatte not sure if you saw my comment on Friday. Ps-th is ready. I'm trying to look over Apa Johannes tonight
ok that was easy! Apa Johannes is ready.
Also I don't know why it's telling me "Metadata for facsimile_graphic_url does not match pattern"
I'm not sure about that, either. I didn't change the meta, and I'm pretty sure it was all validating before. I've just checked the TEI for all of Apa Johannes and re-checked ps-Theophilus just in case, and it's all valid!
It had double quotes in the href, instead of single quotes. I just changed it, it should all validate now.
Oh thanks. The link functioned in gitdox so I couldn’t tell what was going on.
Yes, double quotes work fine in GitDox, but lead to "
in ANNIS, which breaks the link...
Thanks for the clarification. We can't see that in GitDox, since it turns into a live link.
OK, pseudo.theophilus, AP and johannes are up for review in ANNIS. Talk in a bit...
I've taken a look at all visualizations and all metadata for all new documents, plus corpus metadata, and it all looks good to me.
Corpora scheduled for publication:
[x] ap (assigned to various, review by @ctschroeder or @eplatte)
[x] pseudo theophilus (assigned to @ctschroeder, review by @eplatte?)
[x] johannes.canons (assigned to @eplatte, review by @ctschroeder)
[ ]
Mark if possible (1-5 treebanked, review by @eplatte, alert AZ before making any changes to text and annotations)move to Summer/Fall 2018
Reminder of process:
annotate, add all metadata possible
checklist at wiki
reminder (on checklist): review open issues in your corpus repository -- any further edits need to be made to your document(s) or previously published documents?
mark documents as "under review" in Gitdox, assign to editor listed above, and contact us
senior editor will follow remaining wiki checklist, get back to original editor about any patterns/systemic things, and review open issues
version # is 2.5.0, version date is 2018-04-01