CopticScriptorium / corpora

Public repository for Coptic SCRIPTORIUM Corpora Releases
31 stars 13 forks source link

Some .config files have spaces instead of tabs #29

Closed lgessler closed 4 years ago

lgessler commented 5 years ago

E.g. analytic.config for shenoute.fox, where "translation" in the first column is followed by a space.

amir-zeldes commented 5 years ago

This looks like a bug... I'm surprised it works at all. I've corrected the source files for the vis definitions, so they should update on the next release. Since ANNIS tolerates this, I think we can skip a hotfix release.

Just in case there are other gremlins like this: can you have the repo config reader also tolerate:

Explanation: Anno names can't contain spaces so the only legitimate way that tab is the first column separator but the first column contains space is if an anno-value trigger has been used:

my_anno="first chapter"\t...
lgessler commented 5 years ago

I used a regex that replaces a first space with a tab, and that seemed to solve the issue for all the corpora.

amir-zeldes commented 5 years ago

OK thanks, we should still leave this issue open until the source data is fixed (should happen via released 3.0, since config templates have been fixed locally)

amir-zeldes commented 4 years ago

Fixed in 31450f6