search

Copyleaks / moodle-plagiarism_copyleaks

Copyleaks Plagiarism plugin for Moodle
GNU General Public License v3.0
3 stars 3 forks source link

Class plagiarism_plugin_copyleaks has a legacy cron method implemented #14

Closed aurelienb1 closed 2 years ago

aurelienb1 commented 2 years ago

See message below, Plagiarism plugins should implement their own schedule tasks

Execute scheduled task: Background processing of obsolete cron files from plagiarism detection plugins(core\task\plagiarism_cron_task) ... started 13:40:40. Current memory use 13Mo. Processing cron function for plagiarism_plugin_copyleaks...... started 13:40:40. Current memory use 13Mo. It has been detected the class plagiarism_plugin_copyleaks has a legacy cron method implemented. Plagiarism plugins should implement their own schedule tasks .... used 0 dbqueries ... used 0.0097770690917969 seconds Scheduled task complete: Background processing of obsolete cron files from plagiarism detection plugins (core\task\plagiarism_cron_task)

CL-BayanAbuawad commented 2 years ago

Hey @aurelienb1,

As you can see in here and here, we do use scheduled tasks, so I am not sure why you are seeing this message.

Might it be because we have an empty cron function?

aurelienb1 commented 2 years ago

Hi,

Yes, i think because you have empty cron function.

I found this in another plagiarism plugin, see MDL-52702 https://tracker.moodle.org/browse/MDL-52702

/**
 * Workaround MDL-52702 before version 3.1.
 */
public function cron() {
    // Do nothing.
    // Workaround MDL-52702 before version 3.1.
    // Affected branches moodle 2.7 - 3.0.
}

Regards