Corail31 / tombstone_lite

Corail Tombstone: Issues & Updates
https://www.curseforge.com/minecraft/mc-mods/corail-tombstone
3 stars 1 forks source link

Suggestions for Alignment #239

Closed katubug closed 2 months ago

katubug commented 2 months ago

Minecraft Version

1.20.1

Forge Version

47.3.7

Hybrid Server

No response

Corail Tombstone Version

8.7.1

What happened?

Hi! I'm putting this in by request so it's not just in the CurseForge comments. I am not sure, off the top of my head, if I can use loottable alignment rewards with KubeJS. But I definitely know I can execute commands, so I would love the ability to increment and decrement alignment that way. My suggestion was this:

/tbknowledge HeyKatu alignment add 0.01 /tbknowledge HeyKatu alignment add -0.20

If -5 is full Dark and +5 is full Light, I think it makes the most sense to be able to change it in small increments.

These are the ideas we mentioned for other things which could change alignment -

Good Alignment:

Bad Alignment:

Gametype

Singleplayer

Happen by testing with only Corail Tombstone on Forge (required)

No

Occurence

occurs all the time

Other relevant mods

No response

Log Link

No response

Valid Launcher

Corail31 commented 2 months ago

Actually, the alignment points have a range from -500 to 500. If it's to have the possibility to reward a little smaller actions, i would prefer to increase theses numbers (multiplied by 10 for example) instead of using decimal values (and rewards more the existing actions to compensate). But, i'm ok to change the command to increase/decrease slowly.

The current rewards are : (and have configs to set the amount)

Good alignment

Bad alignment

I can add some of your ideas about alignment rewards (but not all, you could still add the others with KubeJS). I'll probably add the command in the next release and some ideas not requiring cooldowns (not being exploitable), and look for the others in a future release.

Corail31 commented 2 months ago

I started to add the main changes:

katubug commented 2 months ago

This is all amazing! Thank you so much!! I can't wait to get this integrated :)

Corail31 commented 2 months ago

@katubug I can already send you a "test version" on CurseForge if you want to start to prepare your modpack. But, i still wait to know if this is correct for you ("multiplied by 10"):

If it's to have the possibility to reward a little smaller actions, i would prefer to increase theses numbers (multiplied by 10 for example) instead of using decimal values (and rewards more the existing actions to compensate).

katubug commented 2 months ago

Oh, sorry for not responding to that! It's been a rough day haha. Yes, that's fine, I only suggested the decimals because I thought it was a smaller scale. The scale of whole numbers up to 500 is perfect!

I'm happy to receive a test version! That would be lovely, thank you! I'm about to go to bed for the night but I would test it in the morning. :)

On Tue, Sep 3, 2024, 9:51 PM Corail31 @.***> wrote:

@katubug https://github.com/katubug I can already send you a "test version" on CurseForge if you want to start to prepare your modpack. But, i still wait to know if this is correct for you ("multiplied by 10"):

If it's to have the possibility to reward a little smaller actions, i would prefer to increase theses numbers (multiplied by 10 for example) instead of using decimal values (and rewards more the existing actions to compensate).

— Reply to this email directly, view it on GitHub https://github.com/Corail31/tombstone_lite/issues/239#issuecomment-2327812759, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5XAAGSK3AEGVDDH563ZUZYUTAVCNFSM6AAAAABNSGRZUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHAYTENZVHE . You are receiving this because you were mentioned.Message ID: @.***>

Corail31 commented 2 months ago

@katubug It's morning for me :p It will be a range from -5000 to 5000 (i could even go to 10000). I sent you the message for the test version on CurseForge.

katubug commented 2 months ago

Good morning, haha! And 5000 to -5000 is great :D

On Tue, Sep 3, 2024, 10:10 PM Corail31 @.***> wrote:

@katubug https://github.com/katubug It's morning for me :p It will be a scale of -5000 to 5000 (i could even go to 10000).

— Reply to this email directly, view it on GitHub https://github.com/Corail31/tombstone_lite/issues/239#issuecomment-2327827502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5TXDLJHHSWJQ2BWEYDZUZ23LAVCNFSM6AAAAABNSGRZUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHAZDONJQGI . You are receiving this because you were mentioned.Message ID: @.***>

Corail31 commented 2 months ago

To resume the whole changes (as i think it will be enough for now and you can add the others with KubeJS):

katubug commented 2 months ago

Amazing, thank you so much! I'll update as soon as it's available!

Corail31 commented 2 months ago

It's published (8.7.2 for 1.20.1).