search

CoralineAda / ambient_spec

Turn your specs into ambient music.
MIT License
40 stars 7 forks source link

Minitest #1

Open HazelGrant opened 9 years ago

HazelGrant commented 9 years ago

Would you welcome a pull request that makes it so that this can run with Minitest? It sounds more fun to me to try and get that working than to spend days and days figuring out how to make my test suite run faster. :)

CoralineAda commented 9 years ago

That would be awesome! Let me know if I can help in any way.

On Feb 25, 2015, at 10:03 PM, Wendy notifications@github.com wrote:

Would you welcome a pull request that makes it so that this can run with Minitest? It sounds more fun to me to try and get that working than to spend days and days figuring out how to make my test suite run faster. :)

— Reply to this email directly or view it on GitHub https://github.com/CoralineAda/ambient_spec/issues/1.

HazelGrant commented 9 years ago

Thanks! I've been doing some research. I was wondering if you could point me to any good examples of gems that allow for integration with either Rspec or Minitest? I'd like to see how other people have handled it.

HazelGrant commented 9 years ago

Hi Coraline,

I've been working on this for a few days and have finally come up with what I think is a viable solution. However, I've run up against a wall and don't know what I'm missing (I'm not really sure how to test what I'm doing except by pulling my changes into my own application and running the test suite to see if it works). I feel like it might be something really obvious such as missing a require or include somewhere. I was wondering if you could spare a few minutes to review my changes and see if there's anything you notice.

What I've done is hook into Minitest::Spec#after, which accepts a block, and I've used the #passed? method from Minitest::Test to determine the flag for #player. (Minitest::Spec inherits from Minitest::Test, so I shouldn't need to require it, right?).

If you could point out anything I've missed or help me figure out how to test this better and produce helpful errors, I would really appreciate it. The idea of trying to generate a fake test suite to run this against is kind of mind-boggling.

Here is the link to the current diff between your work and mine.

CoralineAda commented 9 years ago

Hi Wendy,

I have a party tonight but can definitely look at this tomorrow. Thanks for all the great work!

—Coraline

On Feb 28, 2015, at 3:47 PM, Wendy notifications@github.com wrote:

Hi Coraline,

I've been working on this for a few days and have finally come up with what I think is a viable solution. However, I've run up against a wall and don't know what I'm missing (I'm not really sure how to test what I'm doing except by pulling my changes into my own application and running the test suite to see if it works). I feel like it might be something really obvious such as missing a require or include somewhere. I was wondering if you could spare a few minutes to review my changes and see if there's anything you notice.

What I've done is hook into Minitest::Spec#after, which accepts a block, and I've used the #passed? method from Minitest::Test (which Minitest::Spec inherits from, so I shouldn't need to require it, right?).

If you could point out anything I've missed or help me figure out how to test this better and produce helpful errors, I would really appreciate it. The idea of trying to generate a fake test suite to run this against is kind of mind-boggling.

Here https://github.com/CoralineAda/ambient_spec/compare/master...WendyBeth:minitest-integration is the link to the current diff between your work and mine.

— Reply to this email directly or view it on GitHub https://github.com/CoralineAda/ambient_spec/issues/1#issuecomment-76547830.

CoralineAda commented 9 years ago

Hi Wendy,

I’m lining up someone who is more familiar with minitest than me to help you out if that’s okay with you?

Let me know…

Thank! Coraline

On Feb 26, 2015, at 12:48 AM, Wendy notifications@github.com wrote:

Thanks! I've been doing some research. I was wondering if you could point me to any good examples of gems that allow for integration with either Rspec or Minitest? I'd like to see how other people have handled it.

— Reply to this email directly or view it on GitHub https://github.com/CoralineAda/ambient_spec/issues/1#issuecomment-76130507.

HazelGrant commented 9 years ago

That's great. Thanks for doing that!

CoralineAda commented 9 years ago

Can you email me at coraline@idolhands.com mailto:coraline@idolhands.com? I’ll introduce you to Carol and then you two can pair on this. :)

Best, Coraline

On Mar 3, 2015, at 1:07 AM, Wendy notifications@github.com wrote:

That's great. Thanks for doing that!

— Reply to this email directly or view it on GitHub https://github.com/CoralineAda/ambient_spec/issues/1#issuecomment-76897254.