search

CoralineAda / opensourceforwomen.org

A resource for connecting women in technology with friendly and welcoming open source projects.
MIT License
50 stars 19 forks source link

Fix missing avatar on profile page. #35

Closed djbender closed 9 years ago

CoralineAda commented 9 years ago

The avatar partial needs to be user-aware. As it is written right now it's going to always display the current_user avatar, but for example on the extended profile page it should be the profile's user avatar. Also the same gravatar/avatar partial should be used on the messages index and show pages.

djbender commented 9 years ago

ok!

djbender commented 9 years ago

It looks like the else branch in app/views/messages/index.html.haml uses a different class: avatar-tiny this extraction doesn't take that into consideration. should i also pass in the class strings to this partial?

CoralineAda commented 9 years ago

Yep, good catch.

On Oct 7, 2015, at 10:55 PM, Derek Bender notifications@github.com wrote:

It looks like the else branch in app/views/messages/index.html.haml uses a different class: avatar-tiny this extraction doesn't take that into consideration. should i also pass in the class strings to this partial?

— Reply to this email directly or view it on GitHub https://github.com/CoralineAda/opensourceforwomen.org/pull/35#issuecomment-146412189.

djbender commented 9 years ago

Ready!

CoralineAda commented 9 years ago

Thanks so much Derek!