CoralineAda / opensourceforwomen.org

A resource for connecting women in technology with friendly and welcoming open source projects.
MIT License
50 stars 19 forks source link

Checkboxes on the signup page aren't correctly associated with their labels #53

Open hollsk opened 6 years ago

hollsk commented 6 years ago

On https://www.os4w.org/sign_up all of the checkboxes have an ID that are prepended with the model name, but their associated labels don't. Here's an example (subscribe_me vs user_subscribe_me):

<label class="checkbox" for="subscribe_me">
<input class="checkbox" value="1" type="checkbox" name="user[subscribe_me]" id="user_subscribe_me">
Subscribe to our mailing list
</label>

I had a look in the view template to see if I could open a PR, but I don't really understand how the helper works for the checkboxes, so wasn't able to correct it without changing the markup/layout 😉