Corbeno / Idleon-Api-Downloader

Allows for the downloading of API data in JSON format sent to the browser when Idleon is loaded
17 stars 7 forks source link

Error Handling and Update function adjustments #9

Closed Morta1 closed 3 years ago

Morta1 commented 3 years ago

Added logic to chrome.storage.onChanged.addListener to make sure the updateAllButtons function runs only once. Changed the logic to display an error by CSS instead of JS.

Corbeno commented 3 years ago

It would be a good idea to split up this pull request. I'm totally fine with handling a bunch of small pull requests at the same time (it's actually preferred). It just makes things easier for everyone.

Could you please try these changes (I just reverted popup.js to how it was before) and make sure everything works on your end? If you want, you can open a new PR with the popup.js changes you wanted, and we can discuss it further there.