search

Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
469 stars 125 forks source link

Angular 11 support #112

Closed inexuscore closed 3 years ago

inexuscore commented 3 years ago

Hello, Thanks a lot for making this repo. Is this actively maintained? Any plans to update and support Angular 11 any time soon?

KingDarBoja commented 3 years ago

I will submit a PR which should support Angular 11.

maximodee commented 3 years ago

Currently doesn't appear to be working on Angular 11 so would be great to have a supported version.

a1development commented 3 years ago

Support for Angular 11 would be great.

AndreasGassmann commented 3 years ago

We're using this library in an angular 11 project that has been updated from angular 9. I'm not seeing any issues. Due to some earlier issues with this library, we set the target to "es5", maybe that's the reason it works? What issues do you guys have?

tellybrown commented 3 years ago

We're using this library in an angular 11 project that has been updated from angular 9. I'm not seeing any issues. Due to some earlier issues with this library, we set the target to "es5", maybe that's the reason it works? What issues do you guys have?

When I upgrade it tells me it isn't supported or something to that effect. It was many days ago I tried. I'd be willing to put $10 for it.

tellybrown commented 3 years ago

I found that I upgraded incorrectly. I was on Angular 9 which gave me version 2.3.5. Once I uninstalled it, I could upgrade angular to 11 and then reinstalled. Works perfectly.

AndreasGassmann commented 3 years ago

@tellybrown What's your build target?

tellybrown commented 3 years ago

I am building an IONIC 5 app.

AndreasGassmann commented 3 years ago

@tellybrown In your tsconfig.json, what's the value of the "target" property?

tellybrown commented 3 years ago

{ "compileOnSave": false, "compilerOptions": { "baseUrl": "./", "outDir": "./dist/out-tsc", "sourceMap": true, "declaration": false, "downlevelIteration": true, "experimentalDecorators": true, "module": "es2020", "moduleResolution": "node", "importHelpers": true, "target": "es2015", "lib": [ "es2018", "dom" ] }, "angularCompilerOptions": { "fullTemplateTypeCheck": true, "strictInjectionParameters": true } }

mousedownmike commented 3 years ago

I can confirm that "angularx-qrcode": "10.0.11" is working with "@angular/...": "~11.0.5" and "@angular/material...":"^11.0.3"

tsconfig.json

{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "module": "es2020",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2015",
    "esModuleInterop": true,
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  },
  "angularCompilerOptions": {
    "fullTemplateTypeCheck": false,
    "strictInjectionParameters": true
  }
}
Cordobo commented 3 years ago

Hi @all

thanks for reporting this issue and sorry for the delay, angularx-qrcode@11.0.0 has been released.

Happy coding!