Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
465 stars 126 forks source link

I can't upgrade to angular 12 #129

Closed Caxvalencia closed 2 years ago

Caxvalencia commented 3 years ago

Peer dependency into package file, didn't let me upgrading to angular version lastest

https://github.com/Cordobo/angularx-qrcode/blob/ff61f4c8bbc6c627f9a715aab0b2d6228c8bb2db/package.json#L29

sam-s4s commented 3 years ago

Yes, I had the same thing - had to make sure I installed the newer version of angularx-qrcode before updating angular.

megfault commented 3 years ago

I am also stuck on this library for a v12 upgrade. Thankfully this should be solved soon, see PR #132 :fireworks:

joewIST commented 3 years ago

any update on this?

megfault commented 3 years ago

@Cordobo Pull request #132 should solve this. Can you please have a look?

AbhiThakare commented 3 years ago

Any idea when #132 will merge? please.

jongbonga commented 3 years ago

That's so weird, I'm using it on multiple v12 projects and it's working fine. I guess, I force installed

scifresh commented 3 years ago

I switched to https://github.com/mnahkies/ng-qrcode. It's working fine with Angular 12.

timmyrosen commented 2 years ago

@scifresh Can confirm ng-qrcode is working with Angular 13 as well!

Cordobo commented 2 years ago

Version 12 for angular 12 has been released.