search

Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
465 stars 126 forks source link

update to angular v13 #141

Closed mujiak closed 2 years ago

mujiak commented 2 years ago

update peer dependency to angular v13

inexuscore commented 2 years ago

Any idea when Angular 13 will be supported? We're trying to update to Angular 13 but a few libraries have conflicting peer dependencies. Thank you very much.

specchiasoft commented 2 years ago

Hi i have this error when updating to "@ubirch/angularx-qrcode": library.

"@angular/core": "~13.1.1", "@ubirch/angularx-qrcode": "^13.0.0", dev dependencies: "@types/qrcode": "1.3.5", "typescript": "~4.5.4",

image

inexuscore commented 2 years ago

@angular/core in peer dependencies is targeting > 12 < 13, that's a problem. Is anyone working on this? Unfortunately, I don't have time for submitting a PR at the moment, this is a blocking issue for us trying to upgrade a big project to Angular 13.

Cordobo commented 2 years ago

There should be an updated version for angular 13 within the next few hours.

inexuscore commented 2 years ago

@Cordobo that's great to hear, awesome news! Thank you very much, much appreciated 🍻

specchiasoft commented 2 years ago

There should be an updated version for angular 13 within the next few hours.

Thank you very mutch

Cordobo commented 2 years ago

@inexuscore @specchiasoft

Hi, sorry for the delay, version 13 for angular 13 has been published right now.

Please let me know, if you experience any issues.

inexuscore commented 2 years ago

@Cordobo Hi Cordobo, no problem at all I understand you're busy like everybody else, especially during the holidays. That's awesome! thank you very much, I'll try and update to the latest versions. If I ran into any issues I'll come back with the details. Much appreciated, and happy new year!