Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
468 stars 125 forks source link

alt tag on img in previous library version #166

Closed Pawemol12 closed 2 years ago

Pawemol12 commented 2 years ago

Hello, I'm maintaining old angular 9 project with the angularx-qrcode library of version 2.3.5. I saw the feature https://github.com/Cordobo/angularx-qrcode/issues/161 implemented in new versions of library, but I need it in the 2.3.5 version becouse I can't upgrade angular version in the maintained project :( Is there possibility to add it?

Cordobo commented 2 years ago

True, this should be available for all releases

Could you try angularx-qrcode 2.3.6 and let me know if it works for you?

Edit: This release includes as well a temporary fix for node-qrcode mentioned in #155

Pawemol12 commented 2 years ago

True, this should be available for all releases

Could you try angularx-qrcode 2.3.6 and let me know if it works for you?

Edit: This release includes as well a temporary fix for node-qrcode mentioned in #155

It works but I had to manually add qrcode library: npm install qrcode --save

Becouse otherwise I got this error:

ERROR in The target entry-point "angularx-qrcode" has missing dependencies:

  • qrcode

Idk, if this is my problem or problem in the new version of library

Matiwol commented 2 years ago

Becouse otherwise I got this error:

ERROR in The target entry-point "angularx-qrcode" has missing dependencies:

  • qrcode

Idk, if this is my problem or problem in the new version of library

I have the same error: ERROR in The target entry-point "angularx-qrcode" has missing dependencies:

Pawemol12 commented 2 years ago

@Cordobo can you fix it?

Cordobo commented 2 years ago

Fixed with 2.3.7, please let me know if it works

Pawemol12 commented 2 years ago

Fixed with 2.3.7, please let me know if it works

Tested it - it works.

Cordobo commented 2 years ago

Ok, thanks for the feedback. Closing