search

Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
468 stars 125 forks source link

Does imageSrc work on # angular 8 angularx-qrcode@~2.1.4 ?? #175

Closed biswas-houm closed 2 years ago

biswas-houm commented 2 years ago

I gave a path to the image on imageSrc attribute but does not seem to work. Is this possible with 2.1.4?

biswas-houm commented 2 years ago

Can we make the imageSrc support on lower versions like 2.14 too? Would really love to have that feature.

Cordobo commented 2 years ago

@biswas-houm

yes, this is possible, I'm open for pull requests. If I do it on my own, it'll take some time.

adiynsyah commented 2 years ago

@biswas-houm

yes, this is possible, I'm open for pull requests. If I do it on my own, it'll take some time.

hallo @Cordobo i try in version 11.0.0, i feel my imgSrc is correct path but di qrcode canvas not showing my image

Cordobo commented 2 years ago

When I wrote "this is possible" I referred to the possibility to back-port this feature. It was introduced in version 13 and has been back-ported to version 2.3.7 but not to any other version yet. Sorry for any confusion. As said, I'm open to pull requests to speed the process up a little bit.

Cordobo commented 2 years ago

Closed in favor of #183 183