search

Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
459 stars 127 forks source link

Support for Angular 14 #179

Closed chrisleyva closed 2 years ago

chrisleyva commented 2 years ago

Hello,

Thank you for this great library. I'm sure there are plans to support the latest Angular release (14), I just wanted to create an issue to show that there is need for it in the community 😄 .

Thanks again!

Cordobo commented 2 years ago

Hi @chrisleyva

Support for angular 14 has landed. Happy coding!

eXpertise7 commented 1 year ago

@Cordobo Hey, just a friendly advice, I'd suggest writing changelog docs / release note comments on version upgrades (could be here: https://github.com/Cordobo/angularx-qrcode/tags ). I believe it could be a hassle, since you're not getting paid for it and I understand if you won't do it, but people would have easier time migrating this library to newer versions.

Just migrating angularx-qrcode from 2.3.5 to 14.0.0 and seeing this errors on my Angular 14 project, but ye, I've figured it out that property size is width now and level is errorCorrectionLevel. image

Thanks.

Kind regards, Robert Medved

Cordobo commented 1 year ago

@eXpertise7 Hi, thanks for your comment. I had some hints in the code which logged debug messages to the console while in dev mode. If I remember right, I introduced them in V10 (where the breaking change happened and removed them in V14.

With angular 15 released yesterday, might be worthwhile to reintegrate them into the code.

araujomartin commented 1 year ago

How I make a pull request to add imgsrc from Angular 12 version

Cordobo commented 1 year ago

@araujomartin

angularx-qrcode 14 already supports imageSrc https://github.com/Cordobo/angularx-qrcode/issues/183