Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
468 stars 125 forks source link

Support for Angular 17 #231

Closed Alvaro948 closed 10 months ago

Alvaro948 commented 11 months ago

Hi,

Today has been released Angular 17, can you increment the peer dependencies range to support this version?

https://blog.angular.io/introducing-angular-v17-4d7033312e4b

Thanks for your work!

Just in case anyone needs to update, by forcing the installation it should work

npm install --force

Please, avoid comments like "+1", it sends a notification to anyone subscribed

pil78 commented 10 months ago

+1

John-Santacruz commented 10 months ago

Hi,

Please make this also compatible for angular V17

StefanoVe commented 10 months ago

+1

0xFACE commented 10 months ago

+1

jase88 commented 10 months ago

Alternative to force flag in package.json:

{
  // ...
  "overrides": {
    "angularx-qrcode": {
      "@angular/core": "$@angular/core"
    }
  }
}
Muehli25 commented 10 months ago

232 I created a PR for that!

igorosabel commented 10 months ago

Any news? @Muehli25 's PR should do it

Cordobo commented 10 months ago

Hi @all,

thanks to @Muehli25 for his work on the upgrade for angular 17 and sorry for the delay.

Let me know, if the latest version works for you