search

Cordobo / angularx-qrcode

A fast and easy-to-use Angular QR Code Generator library with Ivy support
https://cordobo.github.io/angularx-qrcode/
MIT License
459 stars 125 forks source link

use the previously unused type. #239

Closed hirotoKirimaru closed 2 months ago

hirotoKirimaru commented 4 months ago

A warning message was signaled regarding the use of 'sample' in Node.js. However, this library's usage of 'QRCodeErrorCorrectionLevel' depends on 'qrcode', not 'angularx-qrcode'. Therefore, I have made adjustments in this commit.

using sample code warning

pasted-2024 02 21-13 25 25

Type string is not assignable to type QRCodeErrorCorrectionLeve

# ASIS
import {QRCodeErrorCorrectionLevel} from "qrcode";

# TOBE
import {QRCodeErrorCorrectionLevel} from "angularx-qrcode";

errorCorrectionLevel: QRCodeErrorCorrectionLevel = 'M';
Cordobo commented 2 months ago

Hi @hirotoKirimaru

thanks for your contribution, I fixed this issue with release 17.0.1.

I'm closing this one.