CoreMedia / content-sync-example

Other
2 stars 4 forks source link

recursion >2 does not work #15

Closed nchieffo closed 3 years ago

nchieffo commented 3 years ago

Preconditions

Create four components (eg. A, B, C, D) on source environment Link content to each other A > B > C > D ("A > B" means that content B is linked to A) Steps to reproduce:

Open Content Sync on sandbox 1 Select source environment with created in preconditions components Select Recursion level to 3 Select content A Actual results: Only A, B, C content items are selected for sync

Expected results: A, B, C, and D content items should be selected for sync

Additional information The expected result is the same when select 4 or 5 recursion level

nchieffo commented 3 years ago

I suggest this patch

Index: modules/extensions/coremedia-content-sync/studio-server/src/main/java/com/coremedia/blueprint/contentsync/model/ContentSyncReferenceModel.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/modules/extensions/coremedia-content-sync/studio-server/src/main/java/com/coremedia/blueprint/contentsync/model/ContentSyncReferenceModel.java b/modules/extensions/coremedia-content-sync/studio-server/src/main/java/com/coremedia/blueprint/contentsync/model/ContentSyncReferenceModel.java
--- a/modules/extensions/coremedia-content-sync/studio-server/src/main/java/com/coremedia/blueprint/contentsync/model/ContentSyncReferenceModel.java    (revision 4c9886e1ca26817ce717284632448c2b5cee099b)
+++ b/modules/extensions/coremedia-content-sync/studio-server/src/main/java/com/coremedia/blueprint/contentsync/model/ContentSyncReferenceModel.java    (date 1622713326895)
@@ -31,7 +31,7 @@
                 subReferences.add(refId.replaceAll(COREMEDIA_CAP_CONTENT,""));
               });
             });
-    references.addAll(subReferences);
+    this.references.addAll(subReferences);
     handleSubReferences(subReferences, ++currentRecursion, maxRecursion);
   }
cmfgi commented 3 years ago

will have a look

cmfgi commented 3 years ago

fixed