search

CoreModding / Group

Group data, config, and standards
The Unlicense
1 stars 0 forks source link

Conventions #1

Open ghost opened 10 years ago

ghost commented 10 years ago

Place group convention plans/ideas here. Continuation of https://github.com/CoreModding/Craftable-Enchantments/issues/2

InternetAthiest commented 10 years ago

I was thinking about a "rule" that when you name your items, blocks and armors you do

ItemSomeItem or BlockSomeBlock ArmorSomeArmor for the class name

ghost commented 10 years ago

I discussed this with teamspeak with him:

It will be added to do ItemSomeItem and BlockSomeBlock rather then itemSomeItem, ect. This should have already been going on, but nobody really enforced it.

All packages should also be ALL lowercase.

ShooShoSha commented 10 years ago

I prefer to keep the items in a package called *.item with sub packages relating those types of items with the actual name as the class. Calling it ItemSomeItem seems redundant. A similar system is applied for blocks.

So, for ItemSomeItem its fully qualified name would be info.coremodding.modid.item.tool.SomeItem giving it clear organization as to what it is and what it may do.

NrdyN8 commented 10 years ago

I hope I am not being too "bossy" here. I will be on the IRC today at approximately 4 MST to discuss the conventions and which ones I want us to follow. I apologize for my absence and I will try and be more involved in the future.

ghost commented 10 years ago

Nobody names their stuff ItemStuffItem. People name it ItemStuff.

Like: BlockFurnace TileFurnace EnityBird ItemHammer IngotIron

Ect

On Mon, Mar 10, 2014 at 6:18 AM, NrdyN8 notifications@github.com wrote:

I hope I am not being to"bossy" here. I will be on the IRC today at approximately 4 MST to discuss the conventions and which ones I want us to follow. I apologize for my absence and I will try and be more involved in the future.

Reply to this email directly or view it on GitHubhttps://github.com/CoreModding/Group/issues/1#issuecomment-37180574 .

ghost commented 10 years ago

All main branches must be the main version being developed. That is 1.7. I think it's a waste of effort that we even have 1.6.4 branches anyway and wish they would all be closed. cough

NrdyN8 commented 10 years ago

We can't when it requested to be 1.6.4.

On Tue, Mar 11, 2014 at 9:23 PM, Zeuslightning125 notifications@github.comwrote:

All main branches must be the main version being developed. That is 1.7. I think it's a waste of effort that we even have 1.6.4 branches anyway and wish they would all be closed. cough

Reply to this email directly or view it on GitHubhttps://github.com/CoreModding/Group/issues/1#issuecomment-37372052 .

ghost commented 10 years ago

The main branch still needs to be the main dev version.

On Tue, Mar 11, 2014 at 9:26 PM, NrdyN8 notifications@github.com wrote:

We can't when it requested to be 1.6.4.

On Tue, Mar 11, 2014 at 9:23 PM, Zeuslightning125 notifications@github.comwrote:

All main branches must be the main version being developed. That is 1.7. I think it's a waste of effort that we even have 1.6.4 branches anyway and wish they would all be closed. cough

Reply to this email directly or view it on GitHub< https://github.com/CoreModding/Group/issues/1#issuecomment-37372052>

.

Reply to this email directly or view it on GitHubhttps://github.com/CoreModding/Group/issues/1#issuecomment-37374489 .

ShooShoSha commented 10 years ago

There is no main development version. It began in 1.7.2 but the client requested it in 1.6.4 so I created branches. I do not want to throw away the 1.7.2 work in case the ask for an update. I spend 95% of development in 1.6.4, but try to make 1.7.2 workable as well.

ghost commented 10 years ago

The team main dev version is 1.7. So the main branch is 1.7, and side branches 1.6.

On Wed, Mar 12, 2014 at 7:59 AM, ShooShoSha notifications@github.comwrote:

There is no main development version. It began in 1.7.2 but the client requested it in 1.6.4 so I created branches. I do not want to throw away the 1.7.2 work in case the ask for an update. I spend 95% of development in 1.6.4, but try to make 1.7.2 workable as well.

Reply to this email directly or view it on GitHubhttps://github.com/CoreModding/Group/issues/1#issuecomment-37418261 .

InternetAthiest commented 10 years ago

ok

ShooShoSha commented 10 years ago

You should checkout the 1.7.2 branch and work with it. It is setup for the gradle environment and you may push changes to it. I may rename or remove the branch called "master" so there are only the minecraft version branches.

ShooShoSha commented 10 years ago

I believe this issue needs to be broken down into more specific topics. This issue ticket covers too many tasks and problems. We should use a milestone to track these issues.