Git Permissions

[ShooShoSha]

I have looked at all the repositories and any issues associated with them. I examined the teams and the repositories they possess. The majority of issues stem from everybody having write access to every repository.There needs to be some control of members pushing any change to the repositories.

[ShooShoSha]

All organization members are encouraged to contribute to whichever repository they would like to get involved. However, it should be up to the team(s) collaborating on that repository to discriminate which changes are made. Thus changes to repositories from non-explicit team members must be made through pull requests.

If you want to avoid managing many pull requests, you may elect to add a member with write privileges if you:

• Communicate well
• Trust their judgement
• Won't despise one another after a mistake
• Other circumstances should be discussed prior to adding team members

[eikap]

Well, in my opinion, we should not work on separate mods, but focus on one of them and get it done, and I think that it's good that we can help each other, so we dont need to use pull requests each time we do anything, because we're a team, and we should work as a team. As such I dissagree with @ShooShoSha.

[NrdyN8]

The way I have it setup is the way is should be. Only the groups with the same name as the mods as well as the Admins can write to it. There is a project ead on each mod and only with expressed written permission from either the mod lead or an admin can someone then be added to the group and be allowed to work on it.

[ShooShoSha]

If priority demands it, we can task members to write code for a specific project if it needs to be completed or repaired quickly. But all those pushes need to have a review process by members of the team of that project; they have the most knowledge of what the client wants and what the mod should do.

Think of team members as a code review panel. They can push anything they want to the repository because they have exclusivity over the project. When someone outside the team makes contributions, you want to make sure it doesn't break all the work you've made. Thus they make pull requests.

The pull requests are only to control what is put into the remote repository. If you want a member to avoid making pull requests, they can be added to the team and be granted explicit write permissions.

[NrdyN8]

Wait, I thought that is what I said. Maybe it wasn't, I don't know. But yes, that is the way I want it and the way it should be.

[ShooShoSha]

@NrdyN8 I wanted to elaborate the thought process I had and what you wrote.

[eikap]

BTW have ShooShoSha replaced zeus as an admin? Tf?

[NrdyN8]

Yes.

[NrdyN8]

Zeus has broken a few rules again. Although Zeus can still return after I see that he has changed.

[eikap]

And why is ShooShoSha an admin? Just curious

[eikap]

And what rules? Do we have any? :/

[NrdyN8]

Yes, I forgot who was on the IRC when I posted them. They will be up saturday when I can get back on the account.

[NrdyN8]

We have a list of rules, it is just that Zeus has been asked before to stop and he didn't. I would have let it go if it was a first offense being that the rules aren't up on the forum yet.

[ShooShoSha]

@MushroomLT If you have suggestions to prevent code push abuse, I would be glad to listen to them.

[eikap]

What "Abuse" do we have now?

[eikap]

I cant suggest how to solve a problem if I dont see the problem itself And, @NrdyN8 why is ShooShoSha an admin?

[NrdyN8]

He has the most experience.

[eikap]

In coding>?

[NrdyN8]

Yep.

[eikap]

Ok

[ShooShoSha]

@MushroomLT The abuse is the lack of discussion when make changes to the remote repos. One issue: CoreModding/CORE-API#2 when the developing version was switched without notice. Also this commit: https://github.com/CoreModding/Craftable-Enchantments/commit/113da653983f8a30fadcac6a4bd84037ab2ffac2 was made without discussion and the message unprofessional.

[ghost]

Who does nrdy? Also, that commit doesnt exist.

On Thu, Mar 13, 2014 at 11:43 AM, ShooShoSha notifications@github.comwrote:

@MushroomLT https://github.com/MushroomLT The abuse is the lack of discussion when make changes to the remote repos. One issue: CoreModding/CORE-API#2 https://github.com/CoreModding/CORE-API/issues/2when the developing version was switched without notice. Also this commit: 113da65https://github.com/CoreModding/Group/commit/113da653983f8a30fadcac6a4bd84037ab2ffac2was made without discussion and the message unprofessional.

Reply to this email directly or view it on GitHubhttps://github.com/CoreModding/Group/issues/6#issuecomment-37571346 .

[NrdyN8]

ShooShoSha

[eikap]

@zeuslightning125 click on Crafttable Enchantments not on the commit id.

[ghost]

I think it's flowing smoothly now. Let me know if you want me to re-open this.