CoreNetwork / Mantle

The main plugin powering majority of features on Flatcore
1 stars 1 forks source link

Add formatting codes to signs #337

Closed riddle closed 9 years ago

riddle commented 9 years ago

Re: #334

Simply allow people with mantle.perks.advsigns to pass &3color and &lformatting codes and replace them with proper JSON.

A sign like this can only be placed in their claim (not a claim they have build trust, a claim they made).

When a claim is removed, those custom signs should be removed as well. This particular functionality could be added to Core, as it already handles unclaiming and resizing for liquids. Your choice.

Breaking a sign with color/formatting codes should not drop the item as previously decided in Portals module.

matejdro commented 9 years ago

By the way, color signs also ignore physics at the moment as this is by far the easiest way to prevent dropping if sign support block is removed.

Should we keep that? We could treat it as bonus feature to color signs (Signs in air!).

riddle commented 9 years ago

Neat! Let’s do it :)

riddle commented 9 years ago

BTW that should happen for both wall_sign and sign if I recall correctly.

matejdro commented 9 years ago

Yes.

matejdro commented 9 years ago

Hm it appears we don't even have to bother with JSON. Old system still works.

matejdro commented 9 years ago

OK almost done, only thing left is to add deleting in Core which will I add in the end for all perks.

riddle commented 9 years ago

<3