CoreNetwork / Mantle

The main plugin powering majority of features on Flatcore
1 stars 1 forks source link

Spells lag when Shift+clicked in between inventories unlike any other item #389

Open riddle opened 9 years ago

riddle commented 9 years ago

https://v.usetapes.com/MCHU5siSkt

Any ideas why? I blame client-side ProtocolLib adjustments, can we optimize this so that I don’t have to shift+click some spells twice when first click was too fast to register?

matejdro commented 9 years ago

Hm can you reproduce this reliably? I tried this on my server and could not get it to lag (books move instantly).

riddle commented 9 years ago

Yes, those are the only items with lag when shift+clicking.

eliadil commented 9 years ago

I guess it is because for example, expired spell of unsliming wants to stack with another expired stack of unsliming, but it wont, because the expiration date (invisible to a player) is different? Maybe it happens between the spells of other types too (basically any spell with any spell with any expiration date)

riddle commented 9 years ago

The spells I shift+clicked weren’t expired.

matejdro commented 9 years ago

@riddle Can you reproduce the issue on local server or somewhere else? If yes, can you try removing ProtocolLib?

I can't reproduce the issue locally so it will be hard to debug this.