Fix Decoding of Empty String

CoreOffice / XMLCoder

Easy XML parsing using Codable protocols in Swift

https://coreoffice.github.io/XMLCoder/

MIT License

795 stars 107 forks source link

Fix Decoding of Empty String #145

Closed bwetherfield closed 4 years ago

bwetherfield commented 4 years ago

Prior to this fix, we found that decoding an empty string (represented as a null element), <string/> was confusing the decoder. I can't seem to find any issues logged. Perhaps @jsbean has an idea where these might be hiding...?

I'm also building up to a PR that addresses the array-of-empty-elements issue, but I am trying to disentangle the changes we merged into a separate branch!

bwetherfield commented 4 years ago

This one is now ready for your review, @MaxDesiatov ! Thanks

MaxDesiatov commented 4 years ago

@bwetherfield I'm ready to review this again when conflicts are resolved 🙂

bwetherfield commented 4 years ago

Thanks, @MaxDesiatov ! I also need to add back the missing test :) Will keep you posted

bwetherfield commented 4 years ago

OK - should be ready for review! Thanks, @MaxDesiatov

bwetherfield commented 4 years ago

My apologies, @MaxDesiatov - should be in now!